From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manuel Lauss Subject: Re: [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A Date: Wed, 28 Oct 2009 20:55:14 +0100 Message-ID: References: <1256756954-29211-1-git-send-email-manuel.lauss@gmail.com> <1256756954-29211-2-git-send-email-manuel.lauss@gmail.com> <4AE89D2E.4060704@ru.mvista.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=00151747609a58cb3a0477042cbf Return-path: In-Reply-To: <4AE89D2E.4060704@ru.mvista.com> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org To: Sergei Shtylyov Cc: Andrew Morton , Ralf Baechle , Linux-MIPS , linux-serial@vger.kernel.org, Manuel Lauss List-Id: linux-serial@vger.kernel.org --00151747609a58cb3a0477042cbf Content-Type: text/plain; charset=ISO-8859-1 On Wed, Oct 28, 2009 at 8:36 PM, Sergei Shtylyov wrote: > Hello. > > > Manuel Lauss wrote: > > UART autodetection breaks on the Au1300 but the IP blocks are >> identical, at least in the datasheets. >> > > Pass uart type on to the 8250 driver via platform data, and move >> the MSR quirk to another place sind autoconf() is now no longer >> > > s/sind autoconf/since autoconfig/ > Yeah, I suck at writing descriptions. Will fix. called on init. > Signed-off-by: Manuel Lauss > --- > Tested on DB1200 and DB1300. > The mips parts apply on top of Ralf's mips-queue tree. > > arch/mips/alchemy/common/platform.c | 4 +++- > drivers/serial/8250.c | 13 +++++++------ > 2 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/arch/mips/alchemy/common/platform.c > b/arch/mips/alchemy/common/platform.c > index 195e5b3..3be14b0 100644 > --- a/arch/mips/alchemy/common/platform.c > +++ b/arch/mips/alchemy/common/platform.c > @@ -26,7 +26,9 @@ > .irq = _irq, \ > .regshift = 2, \ > .iotype = UPIO_AU, \ > - .flags = UPF_SKIP_TEST | UPF_IOREMAP \ > + .flags = UPF_SKIP_TEST | UPF_IOREMAP | \ > + UPF_FIXED_TYPE, \ > Good to know this has been implemented. > David Daney implemented this recently for his Octeon port, it's a very handy feature for sure. Thank you ! Manuel Lauss --00151747609a58cb3a0477042cbf Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Wed, Oct 28, 2009 at 8:36 PM, Sergei = Shtylyov <s= shtylyov@ru.mvista.com> wrote:
Hello.


Manuel Lauss wrote:

UART autodetection breaks on the Au1300 but the IP blocks are
identical, at least in the datasheets.

Pass uart type on to the 8250 driver via platform data, and move
the MSR quirk to another place sind autoconf() is now no longer

=A0 s/sind autoconf/since autoconfig/

Yeah, I suck at writing descriptions. Will fix. <= br>

called on init.

Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
---
Tested on DB1200 and DB1300.
The mips parts apply on top of Ralf's mips-queue tree.

=A0arch/mips/alchemy/common/platform.c | =A0 =A04 +++-
=A0drivers/serial/8250.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 13 +++++++------=
=A02 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/arch/mips/alchemy/common/platform.c b/arch/mips/alchemy/common= /platform.c
index 195e5b3..3be14b0 100644
--- a/arch/mips/alchemy/common/platform.c
+++ b/arch/mips/alchemy/common/platform.c
@@ -26,7 +26,9 @@
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.irq =A0 =A0 =A0 =A0 =A0 =A0=3D _irq, =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 \
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.regshift =A0 =A0 =A0 =3D 2, =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0\
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.iotype =A0 =A0 =A0 =A0 =3D UPIO_AU, =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0\
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 .flags =A0 =A0 =A0 =A0 =A0=3D UPF_SKIP_TEST |= UPF_IOREMAP =A0 \
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .flags =A0 =A0 =A0 =A0 =A0=3D UPF_SKIP_TEST |= UPF_IOREMAP | \
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 UPF_FIXED= _TYPE, =A0 =A0 =A0 =A0 =A0 =A0 =A0 \

=A0 Good to know this has been implemented.

David= Daney implemented this recently for his Octeon port, it's a very handy= feature for sure.

Thank you !
=A0=A0=A0=A0=A0 Manuel= Lauss
--00151747609a58cb3a0477042cbf--