Re: [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A

[Manuel Lauss <manuel.lauss@googlemail.com>]

[-- Attachment #1: Type: text/plain, Size: 3135 bytes --]

On Wed, Oct 28, 2009 at 8:52 PM, Andrew Morton <akpm@linux-foundation.org>wrote:

> On Wed, 28 Oct 2009 20:27:16 +0100
> Manuel Lauss <manuel.lauss@googlemail.com> wrote:
>
> > On Wed, Oct 28, 2009 at 8:24 PM, Andrew Morton <
> akpm@linux-foundation.org>wrote:
> >
> > > On Wed, 28 Oct 2009 20:09:14 +0100
> > > Manuel Lauss <manuel.lauss@googlemail.com> wrote:
> > >
> > > > UART autodetection breaks on the Au1300 but the IP blocks are
> > > > identical, at least in the datasheets.
> > > >
> > > > Pass uart type on to the 8250 driver via platform data, and move
> > > > the MSR quirk to another place sind autoconf() is now no longer
> > > > called on init.
> > > >
> > > > Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> > > > ---
> > > > Tested on DB1200 and DB1300.
> > > > The mips parts apply on top of Ralf's mips-queue tree.
> > > >
> > > >  arch/mips/alchemy/common/platform.c |    4 +++-
> > > >  drivers/serial/8250.c               |   13 +++++++------
> > > >  2 files changed, 10 insertions(+), 7 deletions(-)
> > > >
> > > > diff --git a/arch/mips/alchemy/common/platform.c
> > > b/arch/mips/alchemy/common/platform.c
> > > > index 195e5b3..3be14b0 100644
> > > > --- a/arch/mips/alchemy/common/platform.c
> > > > +++ b/arch/mips/alchemy/common/platform.c
> > > > @@ -26,7 +26,9 @@
> > > >               .irq            = _irq,                         \
> > > >               .regshift       = 2,                            \
> > > >               .iotype         = UPIO_AU,                      \
> > > > -             .flags          = UPF_SKIP_TEST | UPF_IOREMAP   \
> > > > +             .flags          = UPF_SKIP_TEST | UPF_IOREMAP | \
> > > > +                               UPF_FIXED_TYPE,               \
> > > > +             .type           = PORT_16550A,                  \
> > > >       }
> > >
> > > The kernel which you patched differs from current mainline here.
> >
> >
> >  I know, that's why I added "The mips parts apply on top of Ralf's
> > mips-queue tree" below
> > the patch description.
>
> If that's the case then Ralf's mips-queue tree isn't in linux-next :(
>
> > If it makes it easier to apply, I could split this one in a mips and in a
> > 8250 patch?
>
> That's a hard call without knowing what's going on in mipsworld.  If
> these patches applied to current mainline we could do it all as one
> patch and, with suitable acks, slap it into 2.6.32.
>

The 8250.c hunks from both patches apply against current -git; only the
mips hunk is against Ralfs queue tree (the mips hunk on its own would
probably break something wrt. modem signals which I can't test now anyway)

I'll resend with a new series: 1 patch with the mips part (to Ralf)
and one with the 8250.c part (to you).



> Are these fixes also appropriate to 2.6.31.x and earlier?  If so,
>

Not really; patch #1 is necessary to get serial going on a chip not
yet supported in mainline, and patch #2 works around failing uart
autodetection on this new soc.


> that's another reason to prepare the patches against current mainline
> and just trample over the mips devel queue.
>

Understood.

Thank you!
     Manuel Lauss

[-- Attachment #2: Type: text/html, Size: 4584 bytes --]