From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manuel Lauss Subject: Re: [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A Date: Wed, 28 Oct 2009 21:11:29 +0100 Message-ID: References: <1256756954-29211-1-git-send-email-manuel.lauss@gmail.com> <1256756954-29211-2-git-send-email-manuel.lauss@gmail.com> <20091028122430.f7670ae2.akpm@linux-foundation.org> <20091028125203.c513883e.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=0023545307d0754afb0477046618 Return-path: In-Reply-To: <20091028125203.c513883e.akpm@linux-foundation.org> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org To: Andrew Morton Cc: Ralf Baechle , Linux-MIPS , linux-serial@vger.kernel.org, Manuel Lauss List-Id: linux-serial@vger.kernel.org --0023545307d0754afb0477046618 Content-Type: text/plain; charset=ISO-8859-1 On Wed, Oct 28, 2009 at 8:52 PM, Andrew Morton wrote: > On Wed, 28 Oct 2009 20:27:16 +0100 > Manuel Lauss wrote: > > > On Wed, Oct 28, 2009 at 8:24 PM, Andrew Morton < > akpm@linux-foundation.org>wrote: > > > > > On Wed, 28 Oct 2009 20:09:14 +0100 > > > Manuel Lauss wrote: > > > > > > > UART autodetection breaks on the Au1300 but the IP blocks are > > > > identical, at least in the datasheets. > > > > > > > > Pass uart type on to the 8250 driver via platform data, and move > > > > the MSR quirk to another place sind autoconf() is now no longer > > > > called on init. > > > > > > > > Signed-off-by: Manuel Lauss > > > > --- > > > > Tested on DB1200 and DB1300. > > > > The mips parts apply on top of Ralf's mips-queue tree. > > > > > > > > arch/mips/alchemy/common/platform.c | 4 +++- > > > > drivers/serial/8250.c | 13 +++++++------ > > > > 2 files changed, 10 insertions(+), 7 deletions(-) > > > > > > > > diff --git a/arch/mips/alchemy/common/platform.c > > > b/arch/mips/alchemy/common/platform.c > > > > index 195e5b3..3be14b0 100644 > > > > --- a/arch/mips/alchemy/common/platform.c > > > > +++ b/arch/mips/alchemy/common/platform.c > > > > @@ -26,7 +26,9 @@ > > > > .irq = _irq, \ > > > > .regshift = 2, \ > > > > .iotype = UPIO_AU, \ > > > > - .flags = UPF_SKIP_TEST | UPF_IOREMAP \ > > > > + .flags = UPF_SKIP_TEST | UPF_IOREMAP | \ > > > > + UPF_FIXED_TYPE, \ > > > > + .type = PORT_16550A, \ > > > > } > > > > > > The kernel which you patched differs from current mainline here. > > > > > > I know, that's why I added "The mips parts apply on top of Ralf's > > mips-queue tree" below > > the patch description. > > If that's the case then Ralf's mips-queue tree isn't in linux-next :( > > > If it makes it easier to apply, I could split this one in a mips and in a > > 8250 patch? > > That's a hard call without knowing what's going on in mipsworld. If > these patches applied to current mainline we could do it all as one > patch and, with suitable acks, slap it into 2.6.32. > The 8250.c hunks from both patches apply against current -git; only the mips hunk is against Ralfs queue tree (the mips hunk on its own would probably break something wrt. modem signals which I can't test now anyway) I'll resend with a new series: 1 patch with the mips part (to Ralf) and one with the 8250.c part (to you). > Are these fixes also appropriate to 2.6.31.x and earlier? If so, > Not really; patch #1 is necessary to get serial going on a chip not yet supported in mainline, and patch #2 works around failing uart autodetection on this new soc. > that's another reason to prepare the patches against current mainline > and just trample over the mips devel queue. > Understood. Thank you! Manuel Lauss --0023545307d0754afb0477046618 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Wed, Oct 28, 2009 at 8:52 PM, Andrew = Morton <a= kpm@linux-foundation.org> wrote:
On Wed, 28 Oct 2009 20:27:16 +0100
Manuel Lauss <manuel.lauss@googlemail.com> wrote:

> On Wed, Oct 28, 2009 at 8:24 PM, Andrew Morton <akpm@linux-foundation.org>wrote:
>
> > On Wed, 28 Oct 2009 20:09:14 +0100
> > Manuel Lauss <m= anuel.lauss@googlemail.com> wrote:
> >
> > > UART autodetection breaks on the Au1300 but the IP blocks ar= e
> > > identical, at least in the datasheets.
> > >
> > > Pass uart type on to the 8250 driver via platform data, and = move
> > > the MSR quirk to another place sind autoconf() is now no lon= ger
> > > called on init.
> > >
> > > Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> > > ---
> > > Tested on DB1200 and DB1300.
> > > The mips parts apply on top of Ralf's mips-queue tree. > > >
> > > =A0arch/mips/alchemy/common/platform.c | =A0 =A04 +++-
> > > =A0drivers/serial/8250.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 1= 3 +++++++------
> > > =A02 files changed, 10 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/arch/mips/alchemy/common/platform.c
> > b/arch/mips/alchemy/common/platform.c
> > > index 195e5b3..3be14b0 100644
> > > --- a/arch/mips/alchemy/common/platform.c
> > > +++ b/arch/mips/alchemy/common/platform.c
> > > @@ -26,7 +26,9 @@
> > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 .irq =A0 =A0 =A0 =A0 =A0 =A0=3D = _irq, =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 \
> > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 .regshift =A0 =A0 =A0 =3D 2, =A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0\
> > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 .iotype =A0 =A0 =A0 =A0 =3D UPIO= _AU, =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0\
> > > - =A0 =A0 =A0 =A0 =A0 =A0 .flags =A0 =A0 =A0 =A0 =A0=3D UPF_= SKIP_TEST | UPF_IOREMAP =A0 \
> > > + =A0 =A0 =A0 =A0 =A0 =A0 .flags =A0 =A0 =A0 =A0 =A0=3D UPF_= SKIP_TEST | UPF_IOREMAP | \
> > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 UPF_FIXED_TYPE, =A0 =A0 =A0 =A0 =A0 =A0 =A0 \
> > > + =A0 =A0 =A0 =A0 =A0 =A0 .type =A0 =A0 =A0 =A0 =A0 =3D PORT= _16550A, =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0\
> > > =A0 =A0 =A0 }
> >
> > The kernel which you patched differs from current mainline here.<= br> >
>
> =A0I know, that's why I added "The mips parts apply on top of= Ralf's
> mips-queue tree" below
> the patch description.

If that's the case then Ralf's mips-queue tree isn'= t in linux-next :(

> If it makes it easier to apply, I could split this one in a mips and i= n a
> 8250 patch?

That's a hard call without knowing what's going on in mipswor= ld. =A0If
these patches applied to current mainline we could do it all as one
patch and, with suitable acks, slap it into 2.6.32.
The 8250.c hunks from both patches apply against current -git; only themips hunk is against Ralfs queue tree (the mips hunk on its own would
probably break something wrt. modem signals which I can't test now anyw= ay)

I'll resend with a new series: 1 patch with the mips part (t= o Ralf)
and one with the 8250.c part (to you).

=A0
Are these fixes also appropriate to 2.6.31.x and earlier? =A0If so,

Not really; patch #1 is necessary to get serial going on = a chip not
yet supported in mainline, and patch #2 works around failing = uart
autodetection on this new soc.
=A0
that's another reason to prepare the patches against current mainline and just trample over the mips devel queue.

Understood.

Thank you!
=A0=A0=A0=A0 Manuel= Lauss
--0023545307d0754afb0477046618--