From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>
Subject: Re: [PATCH] serial: sc16is7xx: remove unused to_sc16is7xx_port macro
Date: Wed, 6 Sep 2023 13:47:10 +0300 (EEST) [thread overview]
Message-ID: <f8912f92-dda9-9f56-99fa-f3f79d95c86@linux.intel.com> (raw)
In-Reply-To: <20230905181649.134720-1-hugo@hugovil.com>
[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]
On Tue, 5 Sep 2023, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> This macro is not used anywhere.
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
> drivers/tty/serial/sc16is7xx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index f61d98e09dc3..d8534580c6d5 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -358,7 +358,6 @@ static struct uart_driver sc16is7xx_uart = {
> static void sc16is7xx_ier_set(struct uart_port *port, u8 bit);
> static void sc16is7xx_stop_tx(struct uart_port *port);
>
> -#define to_sc16is7xx_port(p,e) ((container_of((p), struct sc16is7xx_port, e)))
> #define to_sc16is7xx_one(p,e) ((container_of((p), struct sc16is7xx_one, e)))
>
> static int sc16is7xx_line(struct uart_port *port)
>
> base-commit: 3f86ed6ec0b390c033eae7f9c487a3fea268e027
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Note that Greg might be happier if you wait next time until after the
merge window is closed before sending non-fixes patch like this.
--
i.
next prev parent reply other threads:[~2023-09-06 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 18:16 [PATCH] serial: sc16is7xx: remove unused to_sc16is7xx_port macro Hugo Villeneuve
2023-09-06 10:47 ` Ilpo Järvinen [this message]
2023-09-06 10:58 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8912f92-dda9-9f56-99fa-f3f79d95c86@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox