From: Jiri Slaby <jirislaby@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Qing Wang <wangqing@vivo.com>
Subject: Re: [PATCH v1 1/1] serial: 8250_mid: Balance reference count for PCI DMA device
Date: Tue, 15 Feb 2022 12:08:26 +0100 [thread overview]
Message-ID: <f8ffca37-6029-6103-e3cf-0c2c62d04485@kernel.org> (raw)
In-Reply-To: <YguBEJ1cc0TMQLuE@smile.fi.intel.com>
On 15. 02. 22, 11:31, Andy Shevchenko wrote:
> On Tue, Feb 15, 2022 at 12:29:49PM +0200, Andy Shevchenko wrote:
>> On Tue, Feb 15, 2022 at 11:11:41AM +0100, Jiri Slaby wrote:
>>> On 15. 02. 22, 11:09, Andy Shevchenko wrote:
>>>> The pci_get_slot() increases its reference count, the caller
>>>> must decrement the reference count by calling pci_dev_put().
>>
>>> And what about the -EINVAL case?
>>
>> What about it? The ->probe() calls ->exit() in its error path.
>> Or did I miss something?
>
> Or you mean that we call pci_dev_put() on NULL pointer?
> This is completely valid case and handled in the callee.
No, I mixed up patches :P. This was meant as a comment to
"serial: 8250_lpss: Balance reference count for PCI DMA device"
byt_serial_exit() isn't called when byt_serial_setup() fails with EINVAL
if I'm looking correctly.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2022-02-15 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 10:09 [PATCH v1 1/1] serial: 8250_mid: Balance reference count for PCI DMA device Andy Shevchenko
2022-02-15 10:11 ` Jiri Slaby
2022-02-15 10:29 ` Andy Shevchenko
2022-02-15 10:31 ` Andy Shevchenko
2022-02-15 11:08 ` Jiri Slaby [this message]
2022-02-15 12:25 ` Andy Shevchenko
2022-02-15 12:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8ffca37-6029-6103-e3cf-0c2c62d04485@kernel.org \
--to=jirislaby@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox