From: George Spelvin <linux@horizon.com>
To: linux-serial@vger.kernel.org, peter@hurleysoftware.com
Cc: linux@horizon.com, linux-kernel@vger.kernel.org, giometti@linux.it
Subject: [PATCH 7/7] tty/tty_ldisc.c: use test_and_clear_bit in tty_ldisc_close
Date: Fri, 8 Feb 2013 01:50:18 -0500 [thread overview]
Message-ID: <faa581736ab4fb46db012cdc42abccaa0bcc16a5.1360307140.git.linux@horizon.com> (raw)
In-Reply-To: <cover.1360307140.git.linux@horizon.com>
We have a function to test and clear a bit in one step, so use it.
Signed-off-by: George Spelvin <linux@horizon.com>
---
drivers/tty/tty_ldisc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
index c578229..4606ab9 100644
--- a/drivers/tty/tty_ldisc.c
+++ b/drivers/tty/tty_ldisc.c
@@ -453,8 +453,7 @@ static int tty_ldisc_open(struct tty_struct *tty, struct tty_ldisc *ld)
static void tty_ldisc_close(struct tty_struct *tty, struct tty_ldisc *ld)
{
- WARN_ON(!test_bit(TTY_LDISC_OPEN, &tty->flags));
- clear_bit(TTY_LDISC_OPEN, &tty->flags);
+ WARN_ON(!test_and_clear_bit(TTY_LDISC_OPEN, &tty->flags));
if (ld->ops->close)
ld->ops->close(tty);
}
--
1.8.1.2
next prev parent reply other threads:[~2013-02-08 9:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 7:05 [PATCH 0/7] 3.8-rc regression with pps-ldisc due to 70ece7a731 George Spelvin
2013-02-06 15:55 ` [PATCH 3/7] pps: Don't crash the machine when exiting will do Peter Hurley
2013-02-06 15:55 ` [PATCH 4/7] tty: Remove ancient hardpps() Peter Hurley
2013-02-08 5:45 ` [PATCH 1/7] pps: Decouple N_PPS from N_TTY George Spelvin
2013-02-08 6:06 ` [PATCH 2/7] pps: Additional cleanups in uart_handle_dcd_change George Spelvin
2013-02-08 6:38 ` [PATCH 5/7] pps: Add pps_lookup_dev() function George Spelvin
2013-02-08 6:48 ` [PATCH 6/7] pps: Use pps_lookup_dev to reduce ldisc coupling George Spelvin
2013-02-08 6:50 ` George Spelvin [this message]
2013-02-08 23:36 ` [PATCH 0/7] 3.8-rc regression with pps-ldisc due to 70ece7a731 Greg KH
2013-02-09 0:22 ` George Spelvin
2013-02-09 7:05 ` George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faa581736ab4fb46db012cdc42abccaa0bcc16a5.1360307140.git.linux@horizon.com \
--to=linux@horizon.com \
--cc=giometti@linux.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).