From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49078C7EE23 for ; Thu, 1 Jun 2023 10:53:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232476AbjFAKxd (ORCPT ); Thu, 1 Jun 2023 06:53:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232146AbjFAKxc (ORCPT ); Thu, 1 Jun 2023 06:53:32 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3D1C8107; Thu, 1 Jun 2023 03:53:31 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3CE902F4; Thu, 1 Jun 2023 03:54:16 -0700 (PDT) Received: from [10.1.26.32] (e122027.cambridge.arm.com [10.1.26.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 185603F7D8; Thu, 1 Jun 2023 03:53:28 -0700 (PDT) Message-ID: Date: Thu, 1 Jun 2023 11:53:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v12 1/1] serial: core: Start managing serial controllers to enable runtime PM Content-Language: en-GB To: Tony Lindgren Cc: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko , Dhruva Gole , =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-omap@vger.kernel.org, Andy Shevchenko , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org References: <20230525113034.46880-1-tony@atomide.com> <20230601104431.GX14287@atomide.com> From: Steven Price In-Reply-To: <20230601104431.GX14287@atomide.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On 01/06/2023 11:44, Tony Lindgren wrote: > Hi, > > * Steven Price [230601 10:04]: >> I haven't studied this change in detail, but I assume the bug is that >> serial_base_port_device_remove() shouldn't be dropping port_mutex. The >> below hack gets my board booting again. > > You're right. I wonder how I managed to miss that.. Care to post a proper > fix for this or do you want me to post it? I'll post a proper fix shortly. Thanks for the confirmation of the fix. >> Thanks, >> >> Steve >> >> Hack fix: >> ----8<---- >> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c >> index 29bd5ede0b25..044e4853341a 100644 >> --- a/drivers/tty/serial/serial_core.c >> +++ b/drivers/tty/serial/serial_core.c >> @@ -3234,8 +3234,7 @@ static void serial_core_remove_one_port(struct uart_driver *drv, >> wait_event(state->remove_wait, !atomic_read(&state->refcount)); >> state->uart_port = NULL; >> mutex_unlock(&port->mutex); >> -out: >> - mutex_unlock(&port_mutex); >> +out:; >> } > > Seems you can remove out here and just do a return earlier instead of goto. Yes, this was just the smallest change. I'll do it properly with an early return in the proper patch. Thanks, Steve > Regards, > > Tony