From: Jiri Slaby <jirislaby@kernel.org>
To: "Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_pnp: Drop unused assignments from pnp_device_id arrays
Date: Tue, 9 Jun 2026 06:33:28 +0200 [thread overview]
Message-ID: <fd9576ec-0dbc-4ecf-bc5d-2630c7df637e@kernel.org> (raw)
In-Reply-To: <dfc218a0e9265e9459df1c5bf621db12be5c551e.1780937987.git.ukleinek@kernel.org>
On 08. 06. 26, 19:00, Uwe Kleine-König (The Capable Hub) wrote:
> Explicitly assigning .driver_data in drivers that don't use this member
> is silly and a bit irritating. Drop these.
You do not do that in the patch though.
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
> drivers/tty/serial/8250/8250_pnp.c | 308 ++++++++++++++---------------
> 1 file changed, 154 insertions(+), 154 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_pnp.c b/drivers/tty/serial/8250/8250_pnp.c
> index 7a837fdf9df1..850709bb4a73 100644
> --- a/drivers/tty/serial/8250/8250_pnp.c
> +++ b/drivers/tty/serial/8250/8250_pnp.c
> @@ -28,351 +28,351 @@
> static const struct pnp_device_id pnp_dev_table[] = {
> /* Archtek America Corp. */
> /* Archtek SmartLink Modem 3334BT Plug & Play */
> - { "AAC000F", 0 },
> + { .id = "AAC000F", .driver_data = 0 },
> /* Anchor Datacomm BV */
...
--
js
suse labs
next prev parent reply other threads:[~2026-06-09 4:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 17:00 [PATCH] serial: 8250_pnp: Drop unused assignments from pnp_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-06-09 4:33 ` Jiri Slaby [this message]
2026-06-09 6:46 ` Uwe Kleine-König (The Capable Hub)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd9576ec-0dbc-4ecf-bc5d-2630c7df637e@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox