From: Florian Fainelli <f.fainelli@gmail.com>
To: Jonas Gorski <jonas.gorski@gmail.com>,
linux-mips@linux-mips.org, linux-serial@vger.kernel.org
Cc: Ralf Baechle <ralf@linux-mips.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>,
Nicolas Schichan <nschichan@freebox.fr>
Subject: Re: [PATCH 1/3] MIPS: AR7: defer registration of GPIO
Date: Sun, 29 Oct 2017 10:33:20 -0700 [thread overview]
Message-ID: <fe7b4311-b013-b372-68d3-67a656eaf8f2@gmail.com> (raw)
In-Reply-To: <20171029152721.6770-2-jonas.gorski@gmail.com>
On 10/29/2017 08:27 AM, Jonas Gorski wrote:
> When called from prom init code, ar7_gpio_init() will fail as it will
> call gpiochip_add() which relies on a working kmalloc() to alloc
> the gpio_desc array and kmalloc is not useable yet at prom init time.
>
> Move ar7_gpio_init() to ar7_register_devices() (a device_initcall)
> where kmalloc works.
>
> Fixes: 14e85c0e69d5 ("gpio: remove gpio_descs global array")
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2017-10-29 17:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 15:27 [PATCH 0/3] MIPS: AR7: assorted fixes Jonas Gorski
2017-10-29 15:27 ` [PATCH 1/3] MIPS: AR7: defer registration of GPIO Jonas Gorski
2017-10-29 17:33 ` Florian Fainelli [this message]
2017-10-29 15:27 ` [PATCH 2/3] MIPS: AR7: ensure that serial ports are properly set up Jonas Gorski
2017-10-29 17:33 ` Florian Fainelli
2017-10-29 15:27 ` [PATCH RFC 3/3] MIPS: AR7: ensure the port type's FCR value is used Jonas Gorski
2017-11-14 11:02 ` James Hogan
2017-12-28 15:38 ` Jonas Gorski
2018-01-02 8:40 ` James Hogan
2018-01-22 13:07 ` James Hogan
2018-01-22 13:34 ` Greg Kroah-Hartman
2017-11-08 22:03 ` [PATCH 0/3] MIPS: AR7: assorted fixes James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe7b4311-b013-b372-68d3-67a656eaf8f2@gmail.com \
--to=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=nschichan@freebox.fr \
--cc=ralf@linux-mips.org \
--cc=yoshihiro.yunomae.ez@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).