public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Grant Edwards <grante@visi.com>
To: linux-serial@vger.kernel.org
Subject: Re: [PATCH/RFC] 8250: Auto RS485 direction control
Date: Thu, 7 Aug 2008 13:50:28 +0000 (UTC)	[thread overview]
Message-ID: <g7euj4$db9$1@ger.gmane.org> (raw)
In-Reply-To: 200808071050.35380.laurentp@cse-semaphore.com

On 2008-08-07, Laurent Pinchart <laurentp@cse-semaphore.com> wrote:

>> From what I can gather through the man pages it seems inappropriate to
>> add this to termios cflag, though the CRTSCTS flag does set a precedent.
>> I'm an advocate of the idea of introducing a new IOCTL for setting up
>> non standard hand-shaking settings.  I would suggest that things that
>> should be considered in the interface are settings for lead-in and
>> lead-out timing on the direction line (for the use of radio modems for
>> example) and means to specify if it's appropriate to have the CPU spin
>> on the shift register empty flag on the last byte of a block, if RTS
>> timing really is that critical.
>
> I don't think we want to introduce software emulation, but
> feel free to prove me wrong.

I think that should be left up to the author of the driver.  It
seems to me that it would be pretty difficult to do a decent
job of it at the line-discipline layer.  If the author of the
driver for a particular UART wants to do SW emulation of
auto-RTS, then I think that's where it belongs.  Only the UART
driver knows whether there's a shift-register empty interrupt
(and whether that interrupt happens before or after that final
stop bit has been transmitted).

-- 
Grant Edwards                   grante             Yow! I KAISER ROLL?!
                                  at               What good is a Kaiser Roll
                               visi.com            without a little COLE SLAW
                                                   on the SIDE?


  reply	other threads:[~2008-08-07 13:50 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24 11:47 [PATCH/RFC] 8250: Auto RS485 direction control Laurent Pinchart
2008-07-24 11:57 ` Alan Cox
2008-07-24 12:24   ` Russell King
2008-07-24 12:27     ` Alan Cox
2008-07-24 12:52       ` Russell King
2008-07-24 13:00         ` Alan Cox
2008-07-24 13:18         ` Laurent Pinchart
2008-07-24 14:13         ` Matt Schulte
2008-07-24 14:47           ` Russell King
2008-07-24 12:10 ` Russell King
2008-08-04 14:14 ` Tosoni
2008-08-04 14:22   ` Grant Edwards
2008-08-04 14:36   ` Laurent Pinchart
2008-08-04 16:15     ` Grant Edwards
2008-08-04 16:21       ` Grant Edwards
2008-08-05  9:41       ` Laurent Pinchart
2008-08-05 12:55         ` Tosoni
2008-08-06 14:30           ` Christopher Gibson
2008-08-06 16:33             ` Tosoni
2008-08-09 10:08               ` Christopher Gibson
2008-08-07  8:50             ` Laurent Pinchart
2008-08-07 13:50               ` Grant Edwards [this message]
2008-08-10  3:49               ` Christopher Gibson
2008-08-10  3:57               ` Christopher Gibson
2008-08-29 12:22                 ` Christopher Gibson
2008-12-02 13:09                 ` [PATCH/RFC] " Christopher Gibson
2008-12-04 11:14                   ` Christopher Gibson
2008-08-04 16:47     ` [PATCH/RFC] 8250: " Tosoni
2008-08-04 17:46       ` Grant Edwards
2008-08-04 20:59         ` Matt Schulte
2008-08-05  9:23         ` Laurent Pinchart
2008-08-05  9:34         ` Tosoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='g7euj4$db9$1@ger.gmane.org' \
    --to=grante@visi.com \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox