linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grant Edwards <grant.b.edwards@gmail.com>
To: linux-serial@vger.kernel.org
Subject: Re: tty_flip_buffer() from atomic context when low_latency==1
Date: Fri, 19 Aug 2011 20:44:26 +0000 (UTC)	[thread overview]
Message-ID: <j2mhva$nmv$1@dough.gmane.org> (raw)
In-Reply-To: 20110819212416.6f626852@lxorguk.ukuu.org.uk

On 2011-08-19, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

>> But, many drivers appear to call tty_flip_buffer_push() from an atomic
>> context. If that is done with tty->low_latency==1 it turns into a call
>> to flush_to_ldisc(), which then calls disc->ops->receive_buf(), which
>> must not be called from an atomic context.
>
> It's covered under "So don't do that then".

I don't do that, and wasn't asking if I should.

My point was that most of the drivers in the linux kernels sources
_do_ appear to do that, and I don't see how they avoid problems.

For exaple, 8250.c calls tty_flip_buffer_push() from receive_chars(),
calld from serial8250_handle_port(), called from
serial8250_interrupt().

How are problems avoided when tty->low_latency is set?

Is tty->low_latency never allowed to be set for the 8250 driver?

-- 
Grant Edwards               grant.b.edwards        Yow! VICARIOUSLY experience
                                  at               some reason to LIVE!!
                              gmail.com            


  reply	other threads:[~2011-08-19 20:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-19 19:43 tty_flip_buffer() from atomic context when low_latency==1 Grant Edwards
2011-08-19 20:24 ` Alan Cox
2011-08-19 20:44   ` Grant Edwards [this message]
2011-08-19 21:06     ` Alan Cox
2011-08-19 21:24       ` Grant Edwards
2011-08-19 21:31         ` Alan Cox
2011-08-19 21:52           ` Grant Edwards
2011-08-19 22:53             ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='j2mhva$nmv$1@dough.gmane.org' \
    --to=grant.b.edwards@gmail.com \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).