From: Grant Edwards <grant.b.edwards@gmail.com>
To: linux-serial@vger.kernel.org
Subject: Warning about not setting tty->port: what to set it to?
Date: Fri, 11 Jan 2013 20:34:23 +0000 (UTC) [thread overview]
Message-ID: <kcpt0f$ott$1@ger.gmane.org> (raw)
I maintain a serial card driver which, starting with kernel 3.7,
produces this warning when a port is opened:
tty_init_dev: ttyXYZ driver does not set tty->port. This will crash the kernel later. Fix the driver!
The driver still seems to work fine, but apparently I shouldn't expect
it to continue to do so.
What am I supposed to set tty->port _to_ ?
Obviously, it's supposed to point to an instance of the type (struct tty_port).
Is there somewhere in particular I'm supposed to get that structure
instance from?
Am I supposed to allocate/clear one when the port is opened and free
it when the port is closed? Or does the contents the structure
pointed to by tty->port need to be preserved?
Am I expected to do anything with the contents of that structure?
Or am I just providing some storage space for use by the tty layer
code?
--
Grant Edwards grant.b.edwards Yow! I'm young ... I'm
at HEALTHY ... I can HIKE
gmail.com THRU CAPT GROGAN'S LUMBAR
REGIONS!
next reply other threads:[~2013-01-11 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 20:34 Grant Edwards [this message]
2013-01-14 16:51 ` Warning about not setting tty->port: what to set it to? Grant Edwards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='kcpt0f$ott$1@ger.gmane.org' \
--to=grant.b.edwards@gmail.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).