From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Halasa Subject: Re: should RTS init in serial core be tied to CRTSCTS Date: Tue, 06 Mar 2007 21:40:22 +0100 Message-ID: References: <8bd0f97a0703011603m794e00f5x875eb68ad0db05de@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <8bd0f97a0703011603m794e00f5x875eb68ad0db05de@mail.gmail.com> (Mike Frysinger's message of "Thu, 1 Mar 2007 19:03:02 -0500") Sender: linux-kernel-owner@vger.kernel.org To: Mike Frysinger Cc: rmk@arm.linux.org.uk, Linux Kernel Mailing List , linux-serial@vger.kernel.org, Robin Getz List-Id: linux-serial@vger.kernel.org "Mike Frysinger" writes: > /* > * Setup the RTS and DTR signals once the > * port is open and ready to respond. > */ > if (info->tty->termios->c_cflag & CBAUD) > uart_set_mctrl(port, TIOCM_RTS | TIOCM_DTR); > ... > > shouldnt TIOCM_RTS be passed down only when the 'r' is appended to the > boot cmdline ? How would it be useful? CRTSCTS is for CTS only (i.e., the transmission is paused when CTS is inactive), not for RTS. DTR and RTS should be active when the port is open even without CRTSCTS (= without handshaking), it's used for various purposes such as providing +12V to the device (and two pins can supply more power than one - sure, it isn't the best idea). I wouldn't touch that. -- Krzysztof Halasa