linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* should RTS init in serial core be tied to CRTSCTS
@ 2007-03-02  0:03 Mike Frysinger
  2007-03-04 16:20 ` Robin Getz
                   ` (2 more replies)
  0 siblings, 3 replies; 42+ messages in thread
From: Mike Frysinger @ 2007-03-02  0:03 UTC (permalink / raw)
  To: rmk; +Cc: Linux Kernel Mailing List, linux-serial, Robin Getz

the console= bootcmd allows for controlling of the initial state of
flow control by adding/omitting the 'r' suffix ... however, the
uart_startup() function in serial_core.c always calls down into the
serial driver with TIOCM_RTS:
static int uart_startup(...) {
...
            /*
             * Setup the RTS and DTR signals once the
             * port is open and ready to respond.
             */
            if (info->tty->termios->c_cflag & CBAUD)
                uart_set_mctrl(port, TIOCM_RTS | TIOCM_DTR);
...

shouldnt TIOCM_RTS be passed down only when the 'r' is appended to the
boot cmdline ?  perhaps like this:
uart_set_mctrl(port, (info->flags & UIF_CTS_FLOW ? TIOCM_RTS : 0) | TIOCM_DTR);
assuming too that TIOCM_DTR should always be set ...
-mike

^ permalink raw reply	[flat|nested] 42+ messages in thread

end of thread, other threads:[~2007-03-14 23:59 UTC | newest]

Thread overview: 42+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-02  0:03 should RTS init in serial core be tied to CRTSCTS Mike Frysinger
2007-03-04 16:20 ` Robin Getz
2007-03-04 19:46 ` Russell King
2007-03-04 20:42   ` Robin Getz
2007-03-05  8:39     ` Russell King
2007-03-05 17:09   ` Mike Frysinger
2007-03-05 17:39     ` Tosoni
2007-03-05 17:56     ` Russell King
2007-03-05 18:13       ` Mike Frysinger
2007-03-06 20:40 ` Krzysztof Halasa
2007-03-06 23:24   ` Robin Getz
2007-03-07 12:46     ` Krzysztof Halasa
2007-03-07 13:38       ` Oleksiy Kebkal
2007-03-07 15:19       ` Robin Getz
2007-03-07 21:30         ` Oleksiy Kebkal
2007-03-08 13:44           ` Robin Getz
2007-03-08 13:48             ` Russell King
2007-03-08 14:16               ` Carl-Daniel Hailfinger
2007-03-08 14:20                 ` Russell King
2007-03-08 16:51                 ` Krzysztof Halasa
2007-03-08 18:43                   ` Tosoni
2007-03-09 20:39                     ` Krzysztof Halasa
2007-03-12  9:22                       ` Tosoni
2007-03-12 12:59                         ` Krzysztof Halasa
2007-03-14 11:07                           ` Tosoni
2007-03-14 12:44                             ` Krzysztof Halasa
2007-03-14 13:45                               ` Tosoni
2007-03-14 23:59                                 ` Krzysztof Halasa
2007-03-08 14:23               ` Oleksiy Kebkal
2007-03-08 14:28                 ` Russell King
2007-03-08 14:40                   ` Oleksiy Kebkal
2007-03-08 14:25               ` Oleksiy Kebkal
2007-03-08 20:23               ` Robin Getz
2007-03-08 20:40                 ` Russell King
2007-03-08 23:32                   ` Robin Getz
2007-03-09  8:57                     ` Russell King
2007-03-09 14:18                   ` Oleksiy Kebkal
2007-03-07 12:54     ` Oleksiy Kebkal
2007-03-07 13:03       ` Krzysztof Halasa
2007-03-07 20:04         ` Mike Frysinger
2007-03-07  5:13   ` Oleksiy Kebkal
2007-03-07 12:48     ` Krzysztof Halasa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).