* [RFC v2 4/6] serial: core: support deferring serdev controller registration
From: Ulrich Hecht @ 2017-07-17 15:24 UTC (permalink / raw)
To: linux-serial
Cc: linux-renesas-soc, magnus.damm, laurent.pinchart, wsa, robh, peda,
geert, linux-i2c, Ulrich Hecht
In-Reply-To: <1500305076-15570-1-git-send-email-ulrich.hecht+renesas@gmail.com>
serdev controllers may depend on other devices (such as multiplexers)
and thus require deferred probing support.
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
drivers/tty/serial/serial_core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index f534a40..30a8997 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -2785,6 +2785,10 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
uport->line, uport->dev, port, uport->tty_groups);
if (likely(!IS_ERR(tty_dev))) {
device_set_wakeup_capable(tty_dev, 1);
+ } else if (PTR_ERR(tty_dev) == -EPROBE_DEFER) {
+ ret = -EPROBE_DEFER;
+ state->uart_port = NULL;
+ goto out;
} else {
dev_err(uport->dev, "Cannot register tty device on line %d\n",
uport->line);
--
2.7.4
^ permalink raw reply related
* [RFC v2 5/6] max9260: add driver for i2c over GMSL passthrough
From: Ulrich Hecht @ 2017-07-17 15:24 UTC (permalink / raw)
To: linux-serial
Cc: linux-renesas-soc, magnus.damm, laurent.pinchart, wsa, robh, peda,
geert, linux-i2c, Ulrich Hecht
In-Reply-To: <1500305076-15570-1-git-send-email-ulrich.hecht+renesas@gmail.com>
This driver implements tunnelling of i2c requests over GMSL via a
MAX9260 deserializer. It provides an i2c adapter that can be used
to reach devices on the far side of the link.
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
drivers/media/i2c/Kconfig | 6 +
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/max9260.c | 288 ++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 295 insertions(+)
create mode 100644 drivers/media/i2c/max9260.c
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 7641667..a405d67 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -423,6 +423,12 @@ config VIDEO_VPX3220
To compile this driver as a module, choose M here: the
module will be called vpx3220.
+config VIDEO_MAX9260
+ tristate "Maxim MAX9260 GMSL deserializer support"
+ depends on I2C
+ ---help---
+ This driver supports the Maxim MAX9260 GMSL deserializer.
+
comment "Video and audio decoders"
config VIDEO_SAA717X
diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
index 30e856c..3b6f6f2 100644
--- a/drivers/media/i2c/Makefile
+++ b/drivers/media/i2c/Makefile
@@ -67,6 +67,7 @@ obj-$(CONFIG_VIDEO_OV7640) += ov7640.o
obj-$(CONFIG_VIDEO_OV7670) += ov7670.o
obj-$(CONFIG_VIDEO_OV9650) += ov9650.o
obj-$(CONFIG_VIDEO_OV13858) += ov13858.o
+obj-$(CONFIG_VIDEO_MAX9260) += max9260.o
obj-$(CONFIG_VIDEO_MT9M032) += mt9m032.o
obj-$(CONFIG_VIDEO_MT9M111) += mt9m111.o
obj-$(CONFIG_VIDEO_MT9P031) += mt9p031.o
diff --git a/drivers/media/i2c/max9260.c b/drivers/media/i2c/max9260.c
new file mode 100644
index 0000000..ca34e67
--- /dev/null
+++ b/drivers/media/i2c/max9260.c
@@ -0,0 +1,288 @@
+/*
+ * Maxim MAX9260 GMSL Deserializer Driver
+ *
+ * Copyright (C) 2017 Ulrich Hecht
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ */
+
+#include <linux/device.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_gpio.h>
+#include <linux/serdev.h>
+#include <linux/slab.h>
+#include <linux/tty.h>
+
+#define SYNC 0x79
+#define ACK 0xc3
+
+#define RX_FINISHED 0
+#define RX_FRAME_ERROR 1
+#define RX_EXPECT_ACK 2
+#define RX_EXPECT_ACK_DATA 3
+#define RX_EXPECT_DATA 4
+
+struct max9260_device {
+ struct serdev_device *serdev;
+ u8 *rx_buf;
+ int rx_len;
+ int rx_state;
+ wait_queue_head_t rx_wq;
+ struct i2c_adapter adap;
+};
+
+static void wait_for_transaction(struct max9260_device *dev)
+{
+ wait_event_interruptible_timeout(dev->rx_wq,
+ dev->rx_state <= RX_FRAME_ERROR,
+ HZ/2);
+}
+
+static void max9260_transact(struct max9260_device *dev,
+ int expect,
+ u8 *request, int len)
+{
+ serdev_device_mux_select(dev->serdev);
+
+ serdev_device_set_baudrate(dev->serdev, 115200);
+ serdev_device_set_parity(dev->serdev, 1, 0);
+
+ dev->rx_state = expect;
+ serdev_device_write_buf(dev->serdev, request, len);
+
+ wait_for_transaction(dev);
+
+ serdev_device_mux_deselect(dev->serdev);
+}
+
+static int max9260_read_reg(struct max9260_device *dev, int reg)
+{
+ u8 request[] = { 0x79, 0x91, reg, 1 };
+ u8 rx;
+
+ dev->rx_len = 1;
+ dev->rx_buf = ℞
+
+ max9260_transact(dev, RX_EXPECT_ACK_DATA, request, 4);
+
+ if (dev->rx_state == RX_FINISHED)
+ return rx;
+
+ return -EIO;
+}
+
+static int max9260_setup(struct max9260_device *dev)
+{
+ int ret;
+
+ ret = max9260_read_reg(dev, 0x1e);
+
+ if (ret != 0x02) {
+ dev_err(&dev->serdev->dev,
+ "device does not identify as MAX9260\n");
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
+static void max9260_uart_write_wakeup(struct serdev_device *serdev)
+{
+}
+
+static int max9260_uart_receive_buf(struct serdev_device *serdev,
+ const u8 *data, size_t count)
+{
+ struct max9260_device *dev = serdev_device_get_drvdata(serdev);
+ int accepted;
+
+ switch (dev->rx_state) {
+ case RX_FINISHED:
+ dev_dbg(&dev->serdev->dev, "excess data ignored\n");
+ return count;
+
+ case RX_EXPECT_ACK:
+ case RX_EXPECT_ACK_DATA:
+ if (data[0] != ACK) {
+ dev_dbg(&dev->serdev->dev, "frame error");
+ dev->rx_state = RX_FRAME_ERROR;
+ wake_up_interruptible(&dev->rx_wq);
+ return 1;
+ }
+
+ if (dev->rx_state == RX_EXPECT_ACK_DATA) {
+ dev->rx_state = RX_EXPECT_DATA;
+ } else {
+ dev->rx_state = RX_FINISHED;
+ wake_up_interruptible(&dev->rx_wq);
+ }
+ return 1;
+
+ case RX_EXPECT_DATA:
+ accepted = dev->rx_len < count ? dev->rx_len : count;
+
+ memcpy(dev->rx_buf, data, accepted);
+
+ dev->rx_len -= accepted;
+ dev->rx_buf += accepted;
+
+ if (!dev->rx_len) {
+ dev->rx_state = RX_FINISHED;
+ wake_up_interruptible(&dev->rx_wq);
+ }
+
+ return accepted;
+
+ case RX_FRAME_ERROR:
+ dev_dbg(&dev->serdev->dev, "%d bytes ignored\n", count);
+ return count;
+
+ }
+ return 0;
+}
+
+struct serdev_device_ops max9260_serdev_client_ops = {
+ .receive_buf = max9260_uart_receive_buf,
+ .write_wakeup = max9260_uart_write_wakeup,
+};
+
+static u32 max9260_i2c_func(struct i2c_adapter *adapter)
+{
+ return I2C_FUNC_SMBUS_BYTE|I2C_FUNC_SMBUS_BYTE_DATA;
+}
+
+static s32 max9260_smbus_xfer(struct i2c_adapter *adap, u16 addr,
+ unsigned short flags, char read_write, u8 command, int size,
+ union i2c_smbus_data *data)
+{
+ u8 request[] = { SYNC,
+ (addr << 1) + (read_write == I2C_SMBUS_READ),
+ command, 0, 0 };
+ struct max9260_device *dev = i2c_get_adapdata(adap);
+
+ switch (size) {
+ case I2C_SMBUS_BYTE:
+ if (read_write == I2C_SMBUS_WRITE) {
+ max9260_transact(dev, RX_EXPECT_ACK, request, 4);
+ dev_dbg(&adap->dev,
+ "smbus byte - addr 0x%02x, wrote 0x%02x.\n",
+ addr, command);
+ } else {
+ /* TBD */
+ return -EOPNOTSUPP;
+ }
+ break;
+
+ case I2C_SMBUS_BYTE_DATA:
+ request[3] = 1;
+ if (read_write == I2C_SMBUS_WRITE) {
+ request[4] = data->byte;
+ max9260_transact(dev, RX_EXPECT_ACK, request, 5);
+ dev_dbg(&adap->dev,
+ "smbus byte data - addr 0x%02x, wrote 0x%02x at 0x%02x.\n",
+ addr, data->byte, command);
+ } else {
+ dev->rx_len = 1;
+ dev->rx_buf = &data->byte;
+ max9260_transact(dev, RX_EXPECT_ACK_DATA, request, 4);
+ dev_dbg(&adap->dev,
+ "smbus byte data - addr 0x%02x, read 0x%02x at 0x%02x.\n",
+ addr, data->byte, command);
+ }
+ break;
+ default:
+ dev_dbg(&adap->dev,
+ "Unsupported I2C/SMBus command %d\n", size);
+ return -EOPNOTSUPP;
+ }
+
+ if (dev->rx_state != RX_FINISHED) {
+ dev_dbg(&adap->dev, "xfer timed out\n");
+ return -EIO;
+ }
+
+ return 0;
+}
+
+static const struct i2c_algorithm max9260_i2c_algorithm = {
+ .functionality = max9260_i2c_func,
+ .smbus_xfer = max9260_smbus_xfer,
+};
+
+static int max9260_probe(struct serdev_device *serdev)
+{
+ struct max9260_device *dev;
+ struct i2c_adapter *adap;
+ int ret;
+
+ dev = kzalloc(sizeof(*dev), GFP_KERNEL);
+ if (!dev)
+ return -ENOMEM;
+
+ init_waitqueue_head(&dev->rx_wq);
+
+ dev->serdev = serdev;
+ serdev_device_open(serdev);
+ serdev_device_set_drvdata(serdev, dev);
+
+ serdev_device_set_client_ops(serdev, &max9260_serdev_client_ops);
+
+ ret = max9260_setup(dev);
+ if (ret < 0)
+ goto err_free;
+
+ adap = &dev->adap;
+ i2c_set_adapdata(adap, dev);
+
+ adap->owner = THIS_MODULE;
+ adap->algo = &max9260_i2c_algorithm;
+ adap->dev.parent = &serdev->dev;
+ adap->retries = 5;
+ strlcpy(adap->name, dev_name(&serdev->dev), sizeof(adap->name));
+
+ ret = i2c_add_adapter(adap);
+ if (ret < 0)
+ return ret;
+
+ return 0;
+
+err_free:
+ kfree(dev);
+ return ret;
+}
+
+static void max9260_remove(struct serdev_device *serdev)
+{
+ struct max9260_device *dev = serdev_device_get_drvdata(serdev);
+
+ serdev_device_close(dev->serdev);
+
+ kfree(dev);
+}
+
+static const struct of_device_id max9260_dt_ids[] = {
+ { .compatible = "maxim,max9260" },
+ {},
+};
+
+MODULE_DEVICE_TABLE(of, max9260_dt_ids);
+
+static struct serdev_device_driver max9260_driver = {
+ .probe = max9260_probe,
+ .remove = max9260_remove,
+ .driver = {
+ .name = "max9260",
+ .of_match_table = of_match_ptr(max9260_dt_ids),
+ },
+};
+
+module_serdev_device_driver(max9260_driver);
+
+MODULE_DESCRIPTION("Maxim MAX9260 GMSL Deserializer Driver");
+MODULE_AUTHOR("Ulrich Hecht");
+MODULE_LICENSE("GPL");
--
2.7.4
^ permalink raw reply related
* [RFC v2 6/6] ARM: dts: blanche: add SCIF1 and MAX9260 deserializer
From: Ulrich Hecht @ 2017-07-17 15:24 UTC (permalink / raw)
To: linux-serial
Cc: linux-renesas-soc, magnus.damm, laurent.pinchart, wsa, robh, peda,
geert, linux-i2c, Ulrich Hecht
In-Reply-To: <1500305076-15570-1-git-send-email-ulrich.hecht+renesas@gmail.com>
Adds serial port SCIF1 and the MAX9260 deserializers connected to it.
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
arch/arm/boot/dts/r8a7792-blanche.dts | 52 +++++++++++++++++++++++++++++++++++
1 file changed, 52 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7792-blanche.dts b/arch/arm/boot/dts/r8a7792-blanche.dts
index 9b67dca..2ae9a87 100644
--- a/arch/arm/boot/dts/r8a7792-blanche.dts
+++ b/arch/arm/boot/dts/r8a7792-blanche.dts
@@ -21,6 +21,7 @@
aliases {
serial0 = &scif0;
serial1 = &scif3;
+ serial2 = &scif1;
};
chosen {
@@ -186,6 +187,16 @@
gpio = <&gpio11 12 GPIO_ACTIVE_HIGH>;
enable-active-high;
};
+
+ mux: mux-controller {
+ compatible = "gpio-mux";
+ #mux-control-cells = <0>;
+
+ mux-gpios = <&gpio5 12 GPIO_ACTIVE_HIGH>,
+ <&gpio5 13 GPIO_ACTIVE_HIGH>,
+ <&gpio5 14 GPIO_ACTIVE_HIGH>,
+ <&gpio5 15 GPIO_ACTIVE_HIGH>;
+ };
};
&extal_clk {
@@ -202,6 +213,11 @@
function = "scif0";
};
+ scif1_pins: scif1 {
+ groups = "scif1_data";
+ function = "scif1";
+ };
+
scif3_pins: scif3 {
groups = "scif3_data";
function = "scif3";
@@ -246,6 +262,42 @@
status = "okay";
};
+&scif1 {
+ pinctrl-0 = <&scif1_pins>;
+ pinctrl-names = "default";
+
+ status = "okay";
+
+ mux-controls = <&mux>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+ gmsl-deserializer@0 {
+ compatible = "maxim,max9260";
+ reg = <0x8>;
+ };
+ gmsl-deserializer@1 {
+ compatible = "maxim,max9260";
+ reg = <0x9>;
+ };
+ gmsl-deserializer@2 {
+ compatible = "maxim,max9260";
+ reg = <0xa>;
+ };
+ gmsl-deserializer@3 {
+ compatible = "maxim,max9260";
+ reg = <0xb>;
+ };
+ gmsl-deserializer@4 {
+ compatible = "maxim,max9260";
+ reg = <0x4>;
+ };
+ gmsl-deserializer@5 {
+ compatible = "maxim,max9260";
+ reg = <0x5>;
+ };
+};
+
&scif3 {
pinctrl-0 = <&scif3_pins>;
pinctrl-names = "default";
--
2.7.4
^ permalink raw reply related
* Re: [PATCH 7/9] dt-bindings: serial: add compatible for stm32h7
From: Rob Herring @ 2017-07-17 18:46 UTC (permalink / raw)
To: Bich HEMON
Cc: Greg Kroah-Hartman, Mark Rutland, Maxime Coquelin,
Alexandre TORGUE, Jiri Slaby,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
In-Reply-To: <1499958494-19354-8-git-send-email-bich.hemon-qxv4g6HH51o@public.gmane.org>
On Thu, Jul 13, 2017 at 03:08:29PM +0000, Bich HEMON wrote:
> From: Fabrice Gasnier <fabrice.gasnier-qxv4g6HH51o@public.gmane.org>
>
> Introduce new compatibles for "st,stm32h7-usart" and "st,stm32h7-uart".
> This new compatible allow to use optional wake-up interrupt.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier-qxv4g6HH51o@public.gmane.org>
> Signed-off-by: Bich Hemon <bich.hemon-qxv4g6HH51o@public.gmane.org>
> ---
> .../devicetree/bindings/serial/st,stm32-usart.txt | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* [RFC PATCH 0/5] earlycon hang under some conditions
From: Jeffy Chen @ 2017-07-18 4:29 UTC (permalink / raw)
To: linux-kernel
Cc: gregkh, briannorris, dianders, peter, Jeffy Chen,
Sören Brinkmann, Michal Simek, Marc Gonzalez, Jiri Slaby,
Vineet Gupta, linux-serial, linux-snps-arc, linux-arm-kernel
I was testing earlycon with 8250 dw serial console. And it hangs in
these cases:
1/ kernel hang when calling early write function after free_initmem:
a) the earlycon not disabled after the init code(due to keep_bootcon or
not specify a real console to switch to)
b) the early write func is marked as __init, for example 8250_early.
2/ kernel hang when calling early write function after disable unused
clks/pm domain:
a) the earlycon not disabled after the init code
b) the disable unused clks/pm domain kill the requiered clks/pm
domain, since they are not referenced by the earlycon.
3/ kernel hang when calling early write function after the serial
console driver runtime suspended:
a) the earlycon not disabled after the init code
b) the serial console driver's runtime suspend kills the requiered
clks/pm domain, since they are not referenced by the earlycon.
This serial fix 1/ case only.
Jeffy Chen (5):
serial: arc: Remove __init marking from early write
serial: omap: Remove __init marking from early write
serial: xuartps: Remove __init marking from early write
serial: 8250_ingenic: Remove __init marking from early write
serial: 8250_early: Remove __init marking from early write
drivers/tty/serial/8250/8250_early.c | 8 ++++----
drivers/tty/serial/8250/8250_ingenic.c | 8 ++++----
drivers/tty/serial/arc_uart.c | 4 ++--
drivers/tty/serial/omap-serial.c | 13 ++++++-------
drivers/tty/serial/xilinx_uartps.c | 2 +-
5 files changed, 17 insertions(+), 18 deletions(-)
--
2.1.4
^ permalink raw reply
* [RFC PATCH 1/5] serial: arc: Remove __init marking from early write
From: Jeffy Chen @ 2017-07-18 4:29 UTC (permalink / raw)
To: linux-kernel
Cc: gregkh, briannorris, dianders, peter, Jeffy Chen, Jiri Slaby,
Vineet Gupta, linux-serial, linux-snps-arc
In-Reply-To: <1500352203-21513-1-git-send-email-jeffy.chen@rock-chips.com>
The earlycon would be alive outside the init code in these cases:
1/ we have keep_bootcon in cmdline.
2/ we don't have a real console to switch to.
So remove the __init marking to avoid invalid memory access.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/tty/serial/arc_uart.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
index 5ac06fc..77fe306 100644
--- a/drivers/tty/serial/arc_uart.c
+++ b/drivers/tty/serial/arc_uart.c
@@ -549,8 +549,8 @@ static struct console arc_console = {
.data = &arc_uart_driver
};
-static __init void arc_early_serial_write(struct console *con, const char *s,
- unsigned int n)
+static void arc_early_serial_write(struct console *con, const char *s,
+ unsigned int n)
{
struct earlycon_device *dev = con->data;
--
2.1.4
^ permalink raw reply related
* [RFC PATCH 2/5] serial: omap: Remove __init marking from early write
From: Jeffy Chen @ 2017-07-18 4:30 UTC (permalink / raw)
To: linux-kernel
Cc: gregkh, briannorris, dianders, peter, Jeffy Chen, linux-serial,
Jiri Slaby
In-Reply-To: <1500352203-21513-1-git-send-email-jeffy.chen@rock-chips.com>
The earlycon would be alive outside the init code in these cases:
1/ we have keep_bootcon in cmdline.
2/ we don't have a real console to switch to.
So remove the __init marking to avoid invalid memory access.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/tty/serial/omap-serial.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 1ea05ac..7754053 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -1235,21 +1235,20 @@ static int serial_omap_poll_get_char(struct uart_port *port)
#ifdef CONFIG_SERIAL_OMAP_CONSOLE
#ifdef CONFIG_SERIAL_EARLYCON
-static unsigned int __init omap_serial_early_in(struct uart_port *port,
- int offset)
+static unsigned int omap_serial_early_in(struct uart_port *port, int offset)
{
offset <<= port->regshift;
return readw(port->membase + offset);
}
-static void __init omap_serial_early_out(struct uart_port *port, int offset,
- int value)
+static void omap_serial_early_out(struct uart_port *port, int offset,
+ int value)
{
offset <<= port->regshift;
writew(value, port->membase + offset);
}
-static void __init omap_serial_early_putc(struct uart_port *port, int c)
+static void omap_serial_early_putc(struct uart_port *port, int c)
{
unsigned int status;
@@ -1262,8 +1261,8 @@ static void __init omap_serial_early_putc(struct uart_port *port, int c)
omap_serial_early_out(port, UART_TX, c);
}
-static void __init early_omap_serial_write(struct console *console,
- const char *s, unsigned int count)
+static void early_omap_serial_write(struct console *console, const char *s,
+ unsigned int count)
{
struct earlycon_device *device = console->data;
struct uart_port *port = &device->port;
--
2.1.4
^ permalink raw reply related
* [RFC PATCH 3/5] serial: xuartps: Remove __init marking from early write
From: Jeffy Chen @ 2017-07-18 4:30 UTC (permalink / raw)
To: linux-kernel
Cc: gregkh, briannorris, dianders, peter, Jeffy Chen,
Sören Brinkmann, Michal Simek, Jiri Slaby, linux-serial,
linux-arm-kernel
In-Reply-To: <1500352203-21513-1-git-send-email-jeffy.chen@rock-chips.com>
The earlycon would be alive outside the init code in these cases:
1/ we have keep_bootcon in cmdline.
2/ we don't have a real console to switch to.
So remove the __init marking to avoid invalid memory access.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/tty/serial/xilinx_uartps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index fde55dc..31a630a 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -1163,7 +1163,7 @@ static void cdns_uart_console_putchar(struct uart_port *port, int ch)
writel(ch, port->membase + CDNS_UART_FIFO);
}
-static void __init cdns_early_write(struct console *con, const char *s,
+static void cdns_early_write(struct console *con, const char *s,
unsigned n)
{
struct earlycon_device *dev = con->data;
--
2.1.4
^ permalink raw reply related
* [RFC PATCH 4/5] serial: 8250_ingenic: Remove __init marking from early write
From: Jeffy Chen @ 2017-07-18 4:30 UTC (permalink / raw)
To: linux-kernel
Cc: gregkh, briannorris, dianders, peter, Jeffy Chen, linux-serial,
Jiri Slaby
In-Reply-To: <1500352203-21513-1-git-send-email-jeffy.chen@rock-chips.com>
The earlycon would be alive outside the init code in these cases:
1/ we have keep_bootcon in cmdline.
2/ we don't have a real console to switch to.
So remove the __init marking to avoid invalid memory access.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/tty/serial/8250/8250_ingenic.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_ingenic.c b/drivers/tty/serial/8250/8250_ingenic.c
index 4d9dc10..464389b 100644
--- a/drivers/tty/serial/8250/8250_ingenic.c
+++ b/drivers/tty/serial/8250/8250_ingenic.c
@@ -50,17 +50,17 @@ static const struct of_device_id of_match[];
static struct earlycon_device *early_device;
-static uint8_t __init early_in(struct uart_port *port, int offset)
+static uint8_t early_in(struct uart_port *port, int offset)
{
return readl(port->membase + (offset << 2));
}
-static void __init early_out(struct uart_port *port, int offset, uint8_t value)
+static void early_out(struct uart_port *port, int offset, uint8_t value)
{
writel(value, port->membase + (offset << 2));
}
-static void __init ingenic_early_console_putc(struct uart_port *port, int c)
+static void ingenic_early_console_putc(struct uart_port *port, int c)
{
uint8_t lsr;
@@ -71,7 +71,7 @@ static void __init ingenic_early_console_putc(struct uart_port *port, int c)
early_out(port, UART_TX, c);
}
-static void __init ingenic_early_console_write(struct console *console,
+static void ingenic_early_console_write(struct console *console,
const char *s, unsigned int count)
{
uart_console_write(&early_device->port, s, count,
--
2.1.4
^ permalink raw reply related
* [RFC PATCH 5/5] serial: 8250_early: Remove __init marking from early write
From: Jeffy Chen @ 2017-07-18 4:30 UTC (permalink / raw)
To: linux-kernel
Cc: gregkh, briannorris, dianders, peter, Jeffy Chen, Marc Gonzalez,
Jiri Slaby, linux-serial
In-Reply-To: <1500352203-21513-1-git-send-email-jeffy.chen@rock-chips.com>
The earlycon would be alive outside the init code in these cases:
1/ we have keep_bootcon in cmdline.
2/ we don't have a real console to switch to.
So remove the __init marking to avoid invalid memory access.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/tty/serial/8250/8250_early.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c
index 82fc48e..af72ec3 100644
--- a/drivers/tty/serial/8250/8250_early.c
+++ b/drivers/tty/serial/8250/8250_early.c
@@ -37,7 +37,7 @@
#include <asm/io.h>
#include <asm/serial.h>
-static unsigned int __init serial8250_early_in(struct uart_port *port, int offset)
+static unsigned int serial8250_early_in(struct uart_port *port, int offset)
{
int reg_offset = offset;
offset <<= port->regshift;
@@ -60,7 +60,7 @@ static unsigned int __init serial8250_early_in(struct uart_port *port, int offse
}
}
-static void __init serial8250_early_out(struct uart_port *port, int offset, int value)
+static void serial8250_early_out(struct uart_port *port, int offset, int value)
{
int reg_offset = offset;
offset <<= port->regshift;
@@ -89,7 +89,7 @@ static void __init serial8250_early_out(struct uart_port *port, int offset, int
#define BOTH_EMPTY (UART_LSR_TEMT | UART_LSR_THRE)
-static void __init serial_putc(struct uart_port *port, int c)
+static void serial_putc(struct uart_port *port, int c)
{
unsigned int status;
@@ -103,7 +103,7 @@ static void __init serial_putc(struct uart_port *port, int c)
}
}
-static void __init early_serial8250_write(struct console *console,
+static void early_serial8250_write(struct console *console,
const char *s, unsigned int count)
{
struct earlycon_device *device = console->data;
--
2.1.4
^ permalink raw reply related
* Re: [RFC PATCH 1/5] serial: arc: Remove __init marking from early write
From: Greg KH @ 2017-07-18 5:08 UTC (permalink / raw)
To: Jeffy Chen
Cc: linux-kernel, briannorris, dianders, peter, Jiri Slaby,
Vineet Gupta, linux-serial, linux-snps-arc
In-Reply-To: <1500352203-21513-2-git-send-email-jeffy.chen@rock-chips.com>
On Tue, Jul 18, 2017 at 12:29:59PM +0800, Jeffy Chen wrote:
> The earlycon would be alive outside the init code in these cases:
> 1/ we have keep_bootcon in cmdline.
> 2/ we don't have a real console to switch to.
>
> So remove the __init marking to avoid invalid memory access.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
>
I can't apply "RFC" patches. If you have tested and found this series
to be correct, can you resend it without that on the patch?
thanks,
greg k-h
^ permalink raw reply
* [PATCH 0/5] earlycon hang under some conditions
From: Jeffy Chen @ 2017-07-18 6:02 UTC (permalink / raw)
To: linux-kernel
Cc: gregkh, briannorris, dianders, peter, Jeffy Chen,
Sören Brinkmann, Michal Simek, Marc Gonzalez, Jiri Slaby,
Vineet Gupta, linux-serial, linux-snps-arc, linux-arm-kernel
I was testing earlycon with 8250 dw serial console. And it hangs in
these cases:
1/ kernel hang when calling early write function after free_initmem:
a) the earlycon not disabled after the init code(due to keep_bootcon or
not specify a real console to switch to)
b) the early write func is marked as __init, for example 8250_early.
2/ kernel hang when calling early write function after disable unused
clks/pm domain:
a) the earlycon not disabled after the init code
b) the disable unused clks/pm domain kill the requiered clks/pm
domain, since they are not referenced by the earlycon.
3/ kernel hang when calling early write function after the serial
console driver runtime suspended:
a) the earlycon not disabled after the init code
b) the serial console driver's runtime suspend kills the requiered
clks/pm domain, since they are not referenced by the earlycon.
This serial fix 1/ case only.
Jeffy Chen (5):
serial: arc: Remove __init marking from early write
serial: omap: Remove __init marking from early write
serial: xuartps: Remove __init marking from early write
serial: 8250_ingenic: Remove __init marking from early write
serial: 8250_early: Remove __init marking from early write
drivers/tty/serial/8250/8250_early.c | 8 ++++----
drivers/tty/serial/8250/8250_ingenic.c | 8 ++++----
drivers/tty/serial/arc_uart.c | 4 ++--
drivers/tty/serial/omap-serial.c | 13 ++++++-------
drivers/tty/serial/xilinx_uartps.c | 2 +-
5 files changed, 17 insertions(+), 18 deletions(-)
--
2.1.4
^ permalink raw reply
* [PATCH 1/5] serial: arc: Remove __init marking from early write
From: Jeffy Chen @ 2017-07-18 6:02 UTC (permalink / raw)
To: linux-kernel
Cc: gregkh, briannorris, dianders, peter, Jeffy Chen, Jiri Slaby,
Vineet Gupta, linux-serial, linux-snps-arc
In-Reply-To: <1500357778-23169-1-git-send-email-jeffy.chen@rock-chips.com>
The earlycon would be alive outside the init code in these cases:
1/ we have keep_bootcon in cmdline.
2/ we don't have a real console to switch to.
So remove the __init marking to avoid invalid memory access.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/tty/serial/arc_uart.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
index 5ac06fc..77fe306 100644
--- a/drivers/tty/serial/arc_uart.c
+++ b/drivers/tty/serial/arc_uart.c
@@ -549,8 +549,8 @@ static struct console arc_console = {
.data = &arc_uart_driver
};
-static __init void arc_early_serial_write(struct console *con, const char *s,
- unsigned int n)
+static void arc_early_serial_write(struct console *con, const char *s,
+ unsigned int n)
{
struct earlycon_device *dev = con->data;
--
2.1.4
^ permalink raw reply related
* [PATCH 2/5] serial: omap: Remove __init marking from early write
From: Jeffy Chen @ 2017-07-18 6:02 UTC (permalink / raw)
To: linux-kernel
Cc: gregkh, briannorris, dianders, peter, Jeffy Chen, linux-serial,
Jiri Slaby
In-Reply-To: <1500357778-23169-1-git-send-email-jeffy.chen@rock-chips.com>
The earlycon would be alive outside the init code in these cases:
1/ we have keep_bootcon in cmdline.
2/ we don't have a real console to switch to.
So remove the __init marking to avoid invalid memory access.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/tty/serial/omap-serial.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 1ea05ac..7754053 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -1235,21 +1235,20 @@ static int serial_omap_poll_get_char(struct uart_port *port)
#ifdef CONFIG_SERIAL_OMAP_CONSOLE
#ifdef CONFIG_SERIAL_EARLYCON
-static unsigned int __init omap_serial_early_in(struct uart_port *port,
- int offset)
+static unsigned int omap_serial_early_in(struct uart_port *port, int offset)
{
offset <<= port->regshift;
return readw(port->membase + offset);
}
-static void __init omap_serial_early_out(struct uart_port *port, int offset,
- int value)
+static void omap_serial_early_out(struct uart_port *port, int offset,
+ int value)
{
offset <<= port->regshift;
writew(value, port->membase + offset);
}
-static void __init omap_serial_early_putc(struct uart_port *port, int c)
+static void omap_serial_early_putc(struct uart_port *port, int c)
{
unsigned int status;
@@ -1262,8 +1261,8 @@ static void __init omap_serial_early_putc(struct uart_port *port, int c)
omap_serial_early_out(port, UART_TX, c);
}
-static void __init early_omap_serial_write(struct console *console,
- const char *s, unsigned int count)
+static void early_omap_serial_write(struct console *console, const char *s,
+ unsigned int count)
{
struct earlycon_device *device = console->data;
struct uart_port *port = &device->port;
--
2.1.4
^ permalink raw reply related
* [PATCH 3/5] serial: xuartps: Remove __init marking from early write
From: Jeffy Chen @ 2017-07-18 6:02 UTC (permalink / raw)
To: linux-kernel
Cc: gregkh, briannorris, dianders, peter, Jeffy Chen,
Sören Brinkmann, Michal Simek, Jiri Slaby, linux-serial,
linux-arm-kernel
In-Reply-To: <1500357778-23169-1-git-send-email-jeffy.chen@rock-chips.com>
The earlycon would be alive outside the init code in these cases:
1/ we have keep_bootcon in cmdline.
2/ we don't have a real console to switch to.
So remove the __init marking to avoid invalid memory access.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/tty/serial/xilinx_uartps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index fde55dc..31a630a 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -1163,7 +1163,7 @@ static void cdns_uart_console_putchar(struct uart_port *port, int ch)
writel(ch, port->membase + CDNS_UART_FIFO);
}
-static void __init cdns_early_write(struct console *con, const char *s,
+static void cdns_early_write(struct console *con, const char *s,
unsigned n)
{
struct earlycon_device *dev = con->data;
--
2.1.4
^ permalink raw reply related
* [PATCH 4/5] serial: 8250_ingenic: Remove __init marking from early write
From: Jeffy Chen @ 2017-07-18 6:02 UTC (permalink / raw)
To: linux-kernel
Cc: gregkh, briannorris, dianders, peter, Jeffy Chen, linux-serial,
Jiri Slaby
In-Reply-To: <1500357778-23169-1-git-send-email-jeffy.chen@rock-chips.com>
The earlycon would be alive outside the init code in these cases:
1/ we have keep_bootcon in cmdline.
2/ we don't have a real console to switch to.
So remove the __init marking to avoid invalid memory access.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/tty/serial/8250/8250_ingenic.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_ingenic.c b/drivers/tty/serial/8250/8250_ingenic.c
index 4d9dc10..464389b 100644
--- a/drivers/tty/serial/8250/8250_ingenic.c
+++ b/drivers/tty/serial/8250/8250_ingenic.c
@@ -50,17 +50,17 @@ static const struct of_device_id of_match[];
static struct earlycon_device *early_device;
-static uint8_t __init early_in(struct uart_port *port, int offset)
+static uint8_t early_in(struct uart_port *port, int offset)
{
return readl(port->membase + (offset << 2));
}
-static void __init early_out(struct uart_port *port, int offset, uint8_t value)
+static void early_out(struct uart_port *port, int offset, uint8_t value)
{
writel(value, port->membase + (offset << 2));
}
-static void __init ingenic_early_console_putc(struct uart_port *port, int c)
+static void ingenic_early_console_putc(struct uart_port *port, int c)
{
uint8_t lsr;
@@ -71,7 +71,7 @@ static void __init ingenic_early_console_putc(struct uart_port *port, int c)
early_out(port, UART_TX, c);
}
-static void __init ingenic_early_console_write(struct console *console,
+static void ingenic_early_console_write(struct console *console,
const char *s, unsigned int count)
{
uart_console_write(&early_device->port, s, count,
--
2.1.4
^ permalink raw reply related
* [PATCH 5/5] serial: 8250_early: Remove __init marking from early write
From: Jeffy Chen @ 2017-07-18 6:02 UTC (permalink / raw)
To: linux-kernel
Cc: gregkh, briannorris, dianders, peter, Jeffy Chen, Marc Gonzalez,
Jiri Slaby, linux-serial
In-Reply-To: <1500357778-23169-1-git-send-email-jeffy.chen@rock-chips.com>
The earlycon would be alive outside the init code in these cases:
1/ we have keep_bootcon in cmdline.
2/ we don't have a real console to switch to.
So remove the __init marking to avoid invalid memory access.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/tty/serial/8250/8250_early.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c
index 82fc48e..af72ec3 100644
--- a/drivers/tty/serial/8250/8250_early.c
+++ b/drivers/tty/serial/8250/8250_early.c
@@ -37,7 +37,7 @@
#include <asm/io.h>
#include <asm/serial.h>
-static unsigned int __init serial8250_early_in(struct uart_port *port, int offset)
+static unsigned int serial8250_early_in(struct uart_port *port, int offset)
{
int reg_offset = offset;
offset <<= port->regshift;
@@ -60,7 +60,7 @@ static unsigned int __init serial8250_early_in(struct uart_port *port, int offse
}
}
-static void __init serial8250_early_out(struct uart_port *port, int offset, int value)
+static void serial8250_early_out(struct uart_port *port, int offset, int value)
{
int reg_offset = offset;
offset <<= port->regshift;
@@ -89,7 +89,7 @@ static void __init serial8250_early_out(struct uart_port *port, int offset, int
#define BOTH_EMPTY (UART_LSR_TEMT | UART_LSR_THRE)
-static void __init serial_putc(struct uart_port *port, int c)
+static void serial_putc(struct uart_port *port, int c)
{
unsigned int status;
@@ -103,7 +103,7 @@ static void __init serial_putc(struct uart_port *port, int c)
}
}
-static void __init early_serial8250_write(struct console *console,
+static void early_serial8250_write(struct console *console,
const char *s, unsigned int count)
{
struct earlycon_device *device = console->data;
--
2.1.4
^ permalink raw reply related
* Re: [RFC PATCH 1/5] serial: arc: Remove __init marking from early write
From: jeffy @ 2017-07-18 6:06 UTC (permalink / raw)
To: Greg KH
Cc: linux-kernel, briannorris, dianders, peter, Jiri Slaby,
Vineet Gupta, linux-serial, linux-snps-arc
In-Reply-To: <20170718050838.GA7529@kroah.com>
Hi Greg,
On 07/18/2017 01:08 PM, Greg KH wrote:
> On Tue, Jul 18, 2017 at 12:29:59PM +0800, Jeffy Chen wrote:
>> The earlycon would be alive outside the init code in these cases:
>> 1/ we have keep_bootcon in cmdline.
>> 2/ we don't have a real console to switch to.
>>
>> So remove the __init marking to avoid invalid memory access.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> ---
>>
>
> I can't apply "RFC" patches. If you have tested and found this series
> to be correct, can you resend it without that on the patch?
oh, sorry, i'll resend it :)
but i'm still not sure how to fix other hang cases(mentioned in the
cover-letter, earlycon's required clks/pm domain been disabled by ignore
unused initcalls or serial console driver's runtime suspend).
>
> thanks,
>
> greg k-h
>
>
>
^ permalink raw reply
* Re: [RFC v2 5/6] max9260: add driver for i2c over GMSL passthrough
From: Geert Uytterhoeven @ 2017-07-18 6:51 UTC (permalink / raw)
To: Ulrich Hecht
Cc: linux-serial@vger.kernel.org, Linux-Renesas, Magnus Damm,
Laurent Pinchart, Wolfram Sang, Rob Herring, Peter Rosin,
Linux I2C
In-Reply-To: <1500305076-15570-6-git-send-email-ulrich.hecht+renesas@gmail.com>
Hi Ulrich,
On Mon, Jul 17, 2017 at 5:24 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> This driver implements tunnelling of i2c requests over GMSL via a
> MAX9260 deserializer. It provides an i2c adapter that can be used
> to reach devices on the far side of the link.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Thanks for your patch!
> --- /dev/null
> +++ b/drivers/media/i2c/max9260.c
> @@ -0,0 +1,288 @@
> +static void max9260_transact(struct max9260_device *dev,
> + int expect,
> + u8 *request, int len)
const u8 *request (or const void *?)
> +static int max9260_read_reg(struct max9260_device *dev, int reg)
> +{
> + u8 request[] = { 0x79, 0x91, reg, 1 };
static const
I don't know if this buffer is ever copied. If not, perhaps it should not be
on the stack anyway because some serial drivers may not support DMA
from stack buffers?
This applies to all buffers below.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply
* Re: [RFC v2 6/6] ARM: dts: blanche: add SCIF1 and MAX9260 deserializer
From: Geert Uytterhoeven @ 2017-07-18 6:52 UTC (permalink / raw)
To: Ulrich Hecht
Cc: linux-serial@vger.kernel.org, Linux-Renesas, Magnus Damm,
Laurent Pinchart, Wolfram Sang, Rob Herring, Peter Rosin,
Linux I2C
In-Reply-To: <1500305076-15570-7-git-send-email-ulrich.hecht+renesas@gmail.com>
Hi Uli,
On Mon, Jul 17, 2017 at 5:24 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Adds serial port SCIF1 and the MAX9260 deserializers connected to it.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Thanks for your patch!
> arch/arm/boot/dts/r8a7792-blanche.dts | 52 +++++++++++++++++++++++++++++++++++
> 1 file changed, 52 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7792-blanche.dts b/arch/arm/boot/dts/r8a7792-blanche.dts
> index 9b67dca..2ae9a87 100644
> --- a/arch/arm/boot/dts/r8a7792-blanche.dts
> +++ b/arch/arm/boot/dts/r8a7792-blanche.dts
> status = "okay";
> };
>
> +&scif1 {
> + pinctrl-0 = <&scif1_pins>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +
> + mux-controls = <&mux>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> + gmsl-deserializer@0 {
> + compatible = "maxim,max9260";
> + reg = <0x8>;
unit address and reg property don't match.
(try "make dtbs W=1")
Gr{oetje,eeting}s,
Geert
^ permalink raw reply
* Re: [PATCH] serial: 8250: fix error handling in of_platform_serial_probe()
From: Greg Kroah-Hartman @ 2017-07-18 7:27 UTC (permalink / raw)
To: Alexey Khoroshilov
Cc: Jiri Slaby, Arnd Bergmann, linux-serial, linux-kernel,
ldv-project
In-Reply-To: <1498862969-4919-1-git-send-email-khoroshilov@ispras.ru>
On Sat, Jul 01, 2017 at 01:49:29AM +0300, Alexey Khoroshilov wrote:
> clk_disable_unprepare(info->clk) is missed in of_platform_serial_probe(),
> while irq_dispose_mapping(port->irq) is missed in of_platform_serial_setup().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> ---
> drivers/tty/serial/8250/8250_of.c | 20 +++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
I've had to drop this from my tree due to the obvious build warning it
adds to the system. Always test-build your patches before sending them
out, it makes maintainers grumpy when you do not do that :(
greg k-h
^ permalink raw reply
* Re: [PATCH] serial: 8250: fix error handling in of_platform_serial_probe()
From: Alexey Khoroshilov @ 2017-07-18 7:33 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Jiri Slaby, Arnd Bergmann, linux-serial, linux-kernel,
ldv-project
In-Reply-To: <20170718072732.GA15573@kroah.com>
On 18.07.2017 10:27, Greg Kroah-Hartman wrote:
> On Sat, Jul 01, 2017 at 01:49:29AM +0300, Alexey Khoroshilov wrote:
>> clk_disable_unprepare(info->clk) is missed in of_platform_serial_probe(),
>> while irq_dispose_mapping(port->irq) is missed in of_platform_serial_setup().
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
>> ---
>> drivers/tty/serial/8250/8250_of.c | 20 +++++++++++++-------
>> 1 file changed, 13 insertions(+), 7 deletions(-)
>
> I've had to drop this from my tree due to the obvious build warning it
> adds to the system. Always test-build your patches before sending them
> out, it makes maintainers grumpy when you do not do that :(
>
> greg k-h
>
The problem is in conflict with e2860e1f62f2 "serial: 8250_of: Add reset
support" that was not in the Linus tree when the patch was developed.
I will rebase the patch and resend it.
--
Alexey
^ permalink raw reply
* Re: [PATCH v4 0/2] Add basic support for Mediatek MT2712 SoC
From: YT Shen @ 2017-07-18 7:46 UTC (permalink / raw)
To: Matthias Brugger, Rob Herring
Cc: Mark Rutland, Thomas Gleixner, Jason Cooper, Marc Zyngier,
Greg Kroah-Hartman, Catalin Marinas, Will Deacon, Mars Cheng,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-serial-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w
In-Reply-To: <1498123975-9748-1-git-send-email-yt.shen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Hi Matthias,
Just a gentle ping.
Should I rebase to 4.13-rc1 and send v5?
Thanks
yt.shen
On Thu, 2017-06-22 at 17:32 +0800, YT Shen wrote:
> MT2712 is a SoC based on 64bit ARMv8 architecture.
> MT2712 share many HW IP with MT8173. This patchset was tested on MT2712 evaluation board, and boot to shell ok.
>
> This series contains document bindings, device tree including interrupt and uart.
>
> Changes compared to v3:
> - use two uart clocks refer to the bindings
>
> Changes compared to v2:
> - remove alias from serial1 to serial5
> - remove initrd-start and initrd-end
> - change GIC_CPU_MASK_SIMPLE(6) to GIC_CPU_MASK_RAW(0x13)
> - change gic-400 reg range
>
> Changes compared to v1:
> - change subject prefix for bindings
> - change device tree license to SPDX tag.
> - change bootargs parameter to DT usage.
> - change intpol-controller to interrupt-controller
>
> YT Shen (2):
> dt-bindings: arm: Add bindings for Mediatek MT2712 SoC Platform
> arm64: dts: Add Mediatek SoC MT2712 and evaluation board dts and
> Makefile
>
> Documentation/devicetree/bindings/arm/mediatek.txt | 4 +
> .../interrupt-controller/mediatek,sysirq.txt | 1 +
> .../devicetree/bindings/serial/mtk-uart.txt | 1 +
> arch/arm64/boot/dts/mediatek/Makefile | 1 +
> arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 32 ++++
> arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 172 +++++++++++++++++++++
> 6 files changed, 211 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt2712-evb.dts
> create mode 100644 arch/arm64/boot/dts/mediatek/mt2712e.dtsi
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH] clk: gemini: Fix reset regression
From: Linus Walleij @ 2017-07-18 9:49 UTC (permalink / raw)
To: Philipp Zabel
Cc: Michael Turquette, Stephen Boyd, linux-clk, Janos Laube,
Paulius Zaleckas, linux-arm-kernel@lists.infradead.org,
Hans Ulli Kroll, Florian Fainelli, Joel Stanley,
Greg Kroah-Hartman, linux-serial@vger.kernel.org
In-Reply-To: <1499874682.6374.57.camel@pengutronix.de>
On Wed, Jul 12, 2017 at 5:51 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> From fab3a9a697e9797ba1c24874d7c43c09dd812e77 Mon Sep 17 00:00:00 2001
> From: Philipp Zabel <p.zabel@pengutronix.de>
> Date: Wed, 12 Jul 2017 17:29:28 +0200
> Subject: [PATCH] reset: make (de)assert report succeess for self-deasserting
> reset drivers
>
> By now there are drivers using shared reset controls and (de)assert
> calls on platforms with self-deasserting reset lines and thus reset
> drivers that do not implement .assert() and .deassert().
> As long as the initial state of the reset line is deasserted, there
> is no reason for a reset_control_assert call to return an error for
> shared reset controls, or for a reset_control_deassert call to return
> an error for either shared or exclusive reset controls: after a call
> to reset_control_deassert the reset line is guaranteed to be deasserted,
> and after a call to reset_control_assert it is valid for the reset
> line to stay deasserted for shared reset controls.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
This patch makes all kind of sense, and I follow your
reasoning.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
In the back of my head I was thinking that the deassert/assert
pair matches a certain SoC driver design pattern I have seen
around:
When a driver use an IP block it enables the clock and takes
the block out of reset.
When it stops using it, it asserts reset and disables the clock.
This is not entirely self-evident, for example why is reset asserted
across say insmod/rmmod/insmod. Just disabling the clock would
be OK, I guess, in most cases. It is just one of those "dances"
that developers do, as if to clear the desk or something.
But I guess there must be cases where doing things in another way
creates problems or power leaks.
I would surely like to understand, from a silicon perspective, why
drivers are so often written like this. I could think of things like
little automata and gates inside the silicon that need to be reset
to minimize off-power consumption but I have no clue if it is
really so.
Yours,
Linus Walleij
^ permalink raw reply
* [PATCH] serial: sprd: clear timeout interrupt only rather than all interrupts
From: Chunyan Zhang @ 2017-07-18 9:58 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-serial, linux-kernel, Lanqing Liu, Chunyan Zhang,
Chunyan Zhang, Orson Zhai
From: Lanqing Liu <lanqing.liu@spreadtrum.com>
On Spreadtrum's serial device, nearly all of interrupts would be cleared
by hardware except timeout interrupt. This patch removed the operation
of clearing all interrupt in irq handler, instead added an if statement
to check if the timeout interrupt is supposed to be cleared.
Wrongly clearing timeout interrupt would lead to uart data stay in rx
fifo, that means the driver cannot read them out anymore.
Signed-off-by: Lanqing Liu <lanqing.liu@spreadtrum.com>
Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
---
drivers/tty/serial/sprd_serial.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c
index 90996ad..f758fe6 100644
--- a/drivers/tty/serial/sprd_serial.c
+++ b/drivers/tty/serial/sprd_serial.c
@@ -63,6 +63,7 @@
/* interrupt clear register */
#define SPRD_ICLR 0x0014
+#define SPRD_ICLR_TIMEOUT BIT(13)
/* line control register */
#define SPRD_LCR 0x0018
@@ -298,7 +299,8 @@ static irqreturn_t sprd_handle_irq(int irq, void *dev_id)
return IRQ_NONE;
}
- serial_out(port, SPRD_ICLR, ~0);
+ if (ims & SPRD_IMSR_TIMEOUT)
+ serial_out(port, SPRD_ICLR, SPRD_ICLR_TIMEOUT);
if (ims & (SPRD_IMSR_RX_FIFO_FULL |
SPRD_IMSR_BREAK_DETECT | SPRD_IMSR_TIMEOUT))
--
2.7.4
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox