From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [alsa-devel] [RFC] [PATCH 3/3] ASoC: add support for Amstrad	E3 (Delta) machine
Date: Wed, 22 Jul 2009 13:39:22 +0200
Message-ID: <s5hhbx50wwl.wl%tiwai@suse.de>
References: <200907220523.01107.jkrzyszt@tis.icnet.pl>
	<20090722110328.GB7622@sirena.org.uk>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-serial-owner@vger.kernel.org>
Received: from cantor2.suse.de ([195.135.220.15]:42358 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751816AbZGVLjY (ORCPT <rfc822;linux-serial@vger.kernel.org>);
	Wed, 22 Jul 2009 07:39:24 -0400
In-Reply-To: <20090722110328.GB7622@sirena.org.uk>
Sender: linux-serial-owner@vger.kernel.org
List-Id: linux-serial@vger.kernel.org
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>, alsa-devel@alsa-project.org, Jonathan McDowell <noodles@earth.li>, Tony Lindgren <tony@atomide.com>, Peter Ujfalusi <peter.ujfalusi@nokia.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, e3-hacking@earth.li, Arun KS <arunks@mistralsolutions.com>, "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>, Alan Cox <alan@lxorguk.ukuu.org.uk>

At Wed, 22 Jul 2009 12:03:28 +0100,
Mark Brown wrote:
> 
> > +	/* Setup pins after corresponding bits if changed */
> > +	if ((bool)snd_soc_dapm_get_pin_status(codec, "Speaker") !=
> > +			(bool)(function & (1 << AMS_DELTA_SPEAKER))) {
> 
> Don't like these casts...  why are they needed?

Because the right side is the bit operation?
The cast doesn't look nice, though...


Takashi