From: sashiko-bot@kernel.org
To: "Shawn Lin" <shawn.lin@rock-chips.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: serial: move sdio_uart from mmc/core to tty/serial
Date: Sat, 10 Oct 2026 10:15:29 +0000 [thread overview]
Message-ID: <sashiko-outbox-166421@kernel.org> (raw)
In-Reply-To: <1791626517-18161-1-git-send-email-shawn.lin@rock-chips.com>
> sdio_uart is an SDIO function driver, not part of the MMC/SDIO core.
> Keeping it in drivers/mmc/core/ is misplaced: it registers to the SDIO
> bus (sdio_register_driver) and only uses the public SDIO API from
> include/linux/mmc/, with no dependency on any mmc core internals.
>
> Other SDIO function drivers live under their respective functional
> subsystem, e.g. the SDIO WiFi drivers are under drivers/net/wireless/.
> sdio_uart should likewise be placed under its functional subsystem, tty,
> just like the PCIe and I2C/SPI transport drivers (men_z135_uart,
> sc16is7xx, max310x) that live under drivers/tty/serial/.
>
> Historically almost all changes to this driver were tty API changes
> (e.g. tty_operations adjustments, alloc_tty_driver removal), yet
> scripts/get_maintainer.pl never listed the TTY maintainers while the
> file lived under drivers/mmc/core/. Moving it under drivers/tty/serial/
> makes get_maintainer.pl report the proper TTY/serial maintainers and
> reviewers, which benefits future maintenance of this driver.
>
> No functional change. The CONFIG_SDIO_UART symbol is intentionally kept
> unchanged to avoid breaking existing configs; the dependency is updated
> to 'TTY && MMC' accordingly.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/1791626517-18161-1-git-send-email-shawn.lin@rock-chips.com?part=1
prev parent reply other threads:[~2026-10-10 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 10:01 [PATCH] tty: serial: move sdio_uart from mmc/core to tty/serial Shawn Lin
2026-10-10 10:15 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-166421@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox