Linux Serial subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Nicolai Buchwitz" <nb@tipi-net.de>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: amba-pl011: honour delay_rts_before_send for every write
Date: Sun, 11 Oct 2026 20:30:24 +0000	[thread overview]
Message-ID: <sashiko-outbox-167451@kernel.org> (raw)
In-Reply-To: <20261011-fix-pl011-rs485-rts-delay-v1-1-5078e61bc408@tipi-net.de>

> While the driver waits out delay_rts_before_send, another write calls
> pl011_start_tx() again. pl011_rs485_tx_start() then switches straight
> to SEND, and the data goes out before the delay has passed.
> 
> Leave the start to the trigger_start_tx timer while it is pending.
> 
> Fixes: 2c1fd53af21b ("serial: amba-pl011: Fix RTS handling in RS485 mode")
> Cc: stable@vger.kernel.org
> Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261011-fix-pl011-rs485-rts-delay-v1-1-5078e61bc408@tipi-net.de?part=1


      reply	other threads:[~2026-10-11 20:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11 20:23 [PATCH] serial: amba-pl011: honour delay_rts_before_send for every write Nicolai Buchwitz
2026-10-11 20:30 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-167451@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=nb@tipi-net.de \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox