Re: [PATCH] serial: core: Shut down a suspended port on removal

[sashiko-bot@kernel.org]

> From: Phil Rosenthal <phil@phil.gs>
> 
> Commit 810d467c11f0 ("serial: core: shut down initialized port on
> removal") calls uart_shutdown() from serial_core_remove_one_port() only
> if the port is initialized.  A port that is removed while suspended is
> not: uart_suspend_port() clears its initialized flag, sets its suspended
> flag and keeps its transmit buffer.  Nothing clears the flag or frees
> the buffer on removal, so both stay in the line's uart_state.
> 
> If the line is reused, the next uart_resume_port() for the new port
> finds the suspended flag set and starts the port up although nobody has
> opened it.  If the uart_driver is unregistered instead, the buffer is
> leaked, as uart_unregister_driver() does not free it.
> 
> Call uart_shutdown() whether or not the port is initialized.  For a port
> that is not initialized it leaves the hardware alone, and it always
> clears the suspended flag and frees the transmit buffer.
> 
> Fixes: 810d467c11f0 ("serial: core: shut down initialized port on removal")
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/r/sashiko-outbox-164404@kernel.org
> Assisted-by: LLM sparse
> Signed-off-by: Phil Rosenthal <phil@phil.gs>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014-serial-remove-suspended-v1-1-fda644ab5f89@phil.gs?part=1