Re: [PATCH v2 1/7] vt: Add con_unblank callback to struct consw

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] vt: Meaningful commit message mismatch regarding con_blank vs con_unblank
--

commit b9997468d0018b5c7f81e52b909c357d93d38641
Author: Thomas Zimmermann <tzimmermann@suse.de>

vt: Add con_unblank callback to struct consw

This commit introduces a new con_unblank callback to struct consw as
the inverse operation of con_blank. It updates console blanking and
unblanking logic to utilize this new callback when implemented, while
falling back to the old semantics otherwise.

> Add struct consw.con_unblank as inverse operation to con_black.

[Severity: Medium]
This isn't a bug, but there's a minor typo here: "con_black" instead of
"con_blank".

> If implemented invoke con_blank to turn the console from blanked to
> unblanked.

[Severity: Medium]
Does this description accurately reflect the code changes? The text states
that con_blank is invoked to turn the console from blanked to unblanked if
the new callback is implemented, but the code actually invokes con_unblank
directly.

Looking at do_unblank_screen() in the diff:

> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
[ ... ]
> @@ -4756,9 +4766,15 @@ void do_unblank_screen(int leaving_gfx)
>  	}
>  
>  	console_blanked = 0;
> -	if (vc->vc_sw->con_blank(vc, VESA_NO_BLANKING, leaving_gfx))
> -		/* Low-level driver cannot restore -> do it ourselves */
> -		update_screen(vc);
> +	if (vc->vc_sw->con_unblank) {
> +		if (vc->vc_sw->con_unblank(vc))
> +			/* Low-level driver cannot restore -> do it ourselves */
> +			update_screen(vc);

The new logic successfully calls con_unblank(vc) instead of con_blank() for
this operation. Could the commit message be updated to clarify that
con_unblank() is invoked directly when transitioning from blanked to
unblanked?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016093357.33294-1-tzimmermann@suse.de?part=1