Re: [PATCH v4 4/4] rust: serdev: Simplify callbacks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] rust: missing #[inline] on OpenGuard::drop
--

commit 3744d6179fccd8a1197885b1019f91d6e5f289b7
Author: Markus Probst <markus.probst@posteo.de>

rust: serdev: Simplify callbacks

This commit initializes the driver's private data directly on PrivateData
and introduces OpenGuard for resource cleanup.

> diff --git a/rust/kernel/serdev.rs b/rust/kernel/serdev.rs
> index c16d6593a8d2d..3f9165e167764 100644
> --- a/rust/kernel/serdev.rs
> +++ b/rust/kernel/serdev.rs
[ ... ]
> @@ -92,24 +88,36 @@ unsafe fn unregister(sdrv: &Opaque<Self::DriverType>) {
>      }
>  }
>  
> +struct OpenGuard<'bound> {
> +    sdev: &'bound Device<device::Bound>,
> +}
> +
> +impl Drop for OpenGuard<'_> {
> +    fn drop(&mut self) {

[Severity: Low]
This isn't a bug, but should the drop method on OpenGuard be annotated with
#[inline]?

The Rust subsystem guidelines recommend using #[inline] on small functions in
abstractions that forward directly to a C binding call, such as the call to
bindings::serdev_device_close() here.

> +        // SAFETY:
> +        // - `self.sdev.as_raw()` is guaranteed to be a pointer to a valid
> +        //   `struct serdev_device`.
> +        // - The existence of self proves that the device is open.
> +        unsafe { bindings::serdev_device_close(self.sdev.as_raw()) };
> +    }
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016-rust_serdev_probe_refactor-v4-0-46832e034757@posteo.de?part=4