From: sashiko-bot@kernel.org
To: "Nicolas Pitre" <nico@fluxnic.net>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/3] vt: don't make VS16 widening depend on earlier screen contents
Date: Mon, 19 Oct 2026 21:23:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-178251@kernel.org> (raw)
In-Reply-To: <b777616c7a63920f36dd34a1ab96e95073d0b013.1792443833.git.npitre@baylibre.com>
> From: Nicolas Pitre <npitre@baylibre.com>
>
> VS16 (U+FE0F) widens the preceding character only when that character
> can be found in the Unicode screen memory. But that memory is allocated
> on demand, when the first double-width character is displayed. Until
> then vc_uniscr_getc() returns 0 and the VS16 is ignored.
>
> The same sequence, e.g. U+203C U+FE0F, therefore takes one column on a
> console that hasn't displayed any double-width character yet, and two
> columns afterwards.
>
> Allocate the Unicode screen memory when a VS16 shows up so the
> preceding character is always available. vc_uniscr_check() populates
> it from the current screen content, which includes that character.
>
> Fixes: 95b05de0a566 ("vt: properly support zero-width Unicode code points")
> Assisted-by: LLM
> Signed-off-by: Nicolas Pitre <npitre@baylibre.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1792443833.git.npitre@baylibre.com?part=1
next prev parent reply other threads:[~2026-10-19 21:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 21:16 [PATCH 0/3] vt: make VS16 emoji widening controllable Nicolas Pitre
2026-10-19 21:16 ` [PATCH 1/3] vt: don't make VS16 widening depend on earlier screen contents Nicolas Pitre
2026-10-19 21:23 ` sashiko-bot [this message]
2026-10-19 21:16 ` [PATCH 2/3] vt: add DEC private mode 2027 to control VS16 widening Nicolas Pitre
2026-10-19 21:19 ` sashiko-bot
2026-10-19 21:16 ` [PATCH 3/3] vt: add DECRQM support to report mode states Nicolas Pitre
2026-10-19 21:22 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-178251@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox