From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: check DMA channel configuration errors
Date: Wed, 21 Oct 2026 21:28:05 +0000 [thread overview]
Message-ID: <sashiko-outbox-180699@kernel.org> (raw)
In-Reply-To: <20261021-submit-serial-8250-dma-config-errors-v1-v1-1-c067587d1ef2@gmail.com>
> serial8250_request_dma() checks channel capabilities but ignores the
> result of configuring either channel. Those checks do not establish
> that the provider accepted the requested slave configuration. If it
> rejects the configuration, startup still selects DMA and later attempts
> transfers on a channel that was not configured successfully.
>
> Return the configuration error after releasing the channels acquired so
> far. Both the common and OMAP startup paths already fall back to PIO when
> requesting DMA fails. Check configuration before allocating the receive
> buffer or mapping the transmit buffer, using the existing unwind paths.
>
> Fixes: 9ee4b83e51f7 ("serial: 8250: Add support for dmaengine")
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261021-submit-serial-8250-dma-config-errors-v1-v1-1-c067587d1ef2@gmail.com?part=1
prev parent reply other threads:[~2026-10-21 21:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 21:18 [PATCH] serial: 8250: check DMA channel configuration errors James Hilliard
2026-10-21 21:28 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-180699@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox