Linux Serial subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: account for partial receive DMA delivery to TTY
Date: Wed, 21 Oct 2026 22:13:25 +0000	[thread overview]
Message-ID: <sashiko-outbox-180719@kernel.org> (raw)
In-Reply-To: <20261021-submit-serial-8250-dma-rx-accounting-v1-v1-1-c11795914ab4@gmail.com>

> tty_insert_flip_string() can accept fewer bytes than requested when the
> flip buffer cannot grow. The DMA receive path advances past the entire
> range regardless, but does not record that some bytes were dropped.
> 
> Increment buf_overrun on a short insertion, as the PIO receive path
> does for a failed character insertion. Keep rx accounting for bytes
> received from hardware and do not retry data after the DMA buffer has
> been released.
> 
> Fixes: 9ee4b83e51f7 ("serial: 8250: Add support for dmaengine")
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261021-submit-serial-8250-dma-rx-accounting-v1-v1-1-c11795914ab4@gmail.com?part=1


      reply	other threads:[~2026-10-21 22:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 22:09 [PATCH] serial: 8250: account for partial receive DMA delivery to TTY James Hilliard
2026-10-21 22:13 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-180719@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=james.hilliard1@gmail.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox