Re: [PATCH] serial: 8250: release the transmit PM reference on shutdown

[sashiko-bot@kernel.org]

> Transmit holds a runtime PM reference until the transmitter-empty path
> clears THRI. A hangup can shut down the port while that reference is still
> held. Shutdown clears the interrupt enables and stops DMA, leaving no TX
> interrupt to release rpm_tx_active. A suppressed DMA completion cannot
> release it either.
> 
> Drop the transmit reference after shutting down TX in both the generic
> and OMAP shutdown paths. Their separate shutdown PM references keep the
> UART accessible throughout cleanup. The exchange in the helper also
> handles shutdown after the normal TX path already released its reference.
> 
> Fixes: d74d5d1b7288 ("tty: serial: 8250_core: add run time pm")
> Reported-by: Raul E Rangel <rrangel@chromium.org>
> Closes: https://lore.kernel.org/r/20261022152019.1621716-1-rrangel@chromium.org
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261022-submit-serial-8250-tx-pm-shutdown-v1-v1-1-0e894afa3bb8@gmail.com?part=1