Linux Serial subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Thomas Zimmermann" <tzimmermann@suse.de>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 1/7] vt: Add con_unblank callback to struct consw
Date: Fri, 23 Oct 2026 13:38:22 +0000	[thread overview]
Message-ID: <sashiko-outbox-182834@kernel.org> (raw)
In-Reply-To: <20261023132448.115747-2-tzimmermann@suse.de>

> Add struct consw.con_unblank as inverse operation to con_blank.
> 
> If implemented invoke con_blank to turn the console from blanked to
> unblanked. Also update the semantics of con_blank in this case: The
> blank parameter of con_blank receives a VESA blank mode from enum
> vesa_blank_mode instead of the hybrid unblank/blank values it has
> used so far.
> 
> With con_unblank not implemented, invoke con_blank for blanking and
> unblanking as before.
> 
> The old semantics of con_blank will be removed when all consoles
> implement con_unblank.
> 
> v3:
> - fix typo in commit description (Helge)
> - add mode_switch parameter to con_unblank
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261023132448.115747-1-tzimmermann@suse.de?part=1


  reply	other threads:[~2026-10-23 13:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23 13:16 [PATCH v3 0/7] vt: Simplify console-blanking interface Thomas Zimmermann
2026-10-23 13:16 ` [PATCH v3 1/7] vt: Add con_unblank callback to struct consw Thomas Zimmermann
2026-10-23 13:38   ` sashiko-bot [this message]
2026-10-23 13:16 ` [PATCH v3 2/7] dummycon: Implement struct consw.con_unblank Thomas Zimmermann
2026-10-23 13:37   ` sashiko-bot
2026-10-23 13:16 ` [PATCH v3 3/7] fbcon: " Thomas Zimmermann
2026-10-23 13:41   ` sashiko-bot
2026-10-23 13:16 ` [PATCH v3 4/7] newport_con: " Thomas Zimmermann
2026-10-23 13:36   ` sashiko-bot
2026-10-23 13:16 ` [PATCH v3 5/7] sticon: " Thomas Zimmermann
2026-10-23 13:35   ` sashiko-bot
2026-10-23 13:16 ` [PATCH v3 6/7] vgacon: " Thomas Zimmermann
2026-10-23 13:39   ` sashiko-bot
2026-10-23 13:16 ` [PATCH v3 7/7] vt: Remove old-style con_blank Thomas Zimmermann
2026-10-23 13:37   ` Greg KH
2026-10-25  7:48     ` Helge Deller
2026-10-26  7:41       ` Thomas Zimmermann
2026-10-23 13:37   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-182834@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox