From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_mid: lock RX DMA timeout flushing
Date: Sat, 24 Oct 2026 06:17:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-183569@kernel.org> (raw)
In-Reply-To: <20261024-submit-serial-8250-mid-rx-lock-v1-v1-1-2b9afdf869d7@gmail.com>
> The Tangier and Denverton DMA timeout handlers call
> serial8250_rx_dma_flush() without holding the UART port lock. The helper
> pauses the transfer, copies received data, updates RX state and terminates
> the channel. The DMA completion callback accesses the same state under the
> port lock, so it can race an unlocked timeout flush. The IRQ-chain lock
> held by serial8250_interrupt() does not serialize the completion callback.
>
> Take the port lock around each timeout flush. Release it before handling
> the UART interrupt, since serial8250_handle_irq() acquires the port lock
> itself.
>
> Fixes: 692aa1905679 ("serial: 8250_mid: Read RX buffer on RX DMA timeout for DNV")
> Fixes: 4831e0d9054c ("serial: 8250_mid: handle interrupt correctly in DMA case")
> Cc: stable@vger.kernel.org
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261024-submit-serial-8250-mid-rx-lock-v1-v1-1-2b9afdf869d7@gmail.com?part=1
prev parent reply other threads:[~2026-10-24 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 6:14 [PATCH] serial: 8250_mid: lock RX DMA timeout flushing James Hilliard
2026-10-24 6:17 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-183569@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox