From: sashiko-bot@kernel.org
To: "Johan Hovold" <johan@kernel.org>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/3] tty: n_hdlc: fix read() hangup race
Date: Wed, 28 Oct 2026 13:26:05 +0000 [thread overview]
Message-ID: <sashiko-outbox-187910@kernel.org> (raw)
In-Reply-To: <20261028132049.728457-3-johan@kernel.org>
> Make sure to set the task state before checking the break conditions in
> the read() wait loop to avoid missing a racing wakeup.
>
> Note that before commit c96cf923a98d ("tty: Don't block on IO when ldisc
> change is pending") a racing task hanging up the tty could get stuck in
> uninterruptible sleep when there are blocked readers, but since then
> read() incorrectly returns -EAGAIN instead.
>
> The false-positive stuck hangup issue was flagged by an LLM.
>
> Fixes: 1035b63d3c6f ("n_hdlc: fix read and write locking")
> Cc: stable@vger.kernel.org # 2.6.38
> Signed-off-by: Johan Hovold <johan@kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261028132049.728457-1-johan@kernel.org?part=2
next prev parent reply other threads:[~2026-10-28 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 13:20 [PATCH 0/3] tty: n_hdlc: fix hangup handling Johan Hovold
2026-10-28 13:20 ` [PATCH 1/3] tty: n_hdlc: fix missing write() hangup check Johan Hovold
2026-10-28 13:27 ` sashiko-bot
2026-10-28 13:20 ` [PATCH 2/3] tty: n_hdlc: fix read() hangup race Johan Hovold
2026-10-28 13:26 ` sashiko-bot [this message]
2026-10-28 13:20 ` [PATCH 3/3] tty: n_hdlc: fix read() hangup check Johan Hovold
2026-10-28 13:26 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-187910@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=johan@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox