From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH v5 2/8] serial: 8250: share the RX trigger conversion helper
Date: Thu, 29 Oct 2026 19:10:19 +0000 [thread overview]
Message-ID: <sashiko-outbox-189845@kernel.org> (raw)
In-Reply-To: <20261029-submit-h616-uart-fifo-v1-v5-2-53b433aebbf8@gmail.com>
> Extract the receive-trigger threshold search into serial8250_bytes_to_fcr()
> so drivers with per-port threshold tables can use the same conversion as
> the generic 8250 implementation. Keep the implementation in 8250_port.c and
> export it for subdrivers.
>
> Include the unsupported-table check in the helper and preserve the existing
> nearest-lower selection and highest-encoding fallback.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261029-submit-h616-uart-fifo-v1-v5-0-53b433aebbf8@gmail.com?part=2
next prev parent reply other threads:[~2026-10-29 19:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 18:47 [PATCH v5 0/8] serial: 8250_dw: describe the Allwinner H616 and A523 UART configurations James Hilliard
2026-10-29 18:47 ` [PATCH v5 1/8] serial: 8250_dw: select port setup through platform data James Hilliard
2026-10-29 19:04 ` sashiko-bot
2026-10-30 9:28 ` Ilpo Järvinen
2026-10-29 18:47 ` [PATCH v5 2/8] serial: 8250: share the RX trigger conversion helper James Hilliard
2026-10-29 19:10 ` sashiko-bot [this message]
2026-10-30 9:24 ` Ilpo Järvinen
2026-10-29 18:47 ` [PATCH v5 3/8] dt-bindings: serial: snps-dw-apb-uart: add Allwinner H616 James Hilliard
2026-10-29 19:11 ` sashiko-bot
2026-10-29 18:47 ` [PATCH v5 4/8] serial: 8250_dw: configure the Allwinner H616 UART James Hilliard
2026-10-29 19:17 ` sashiko-bot
2026-10-30 9:51 ` Ilpo Järvinen
2026-10-29 18:47 ` [PATCH v5 5/8] arm64: dts: allwinner: h616: describe the UART integration James Hilliard
2026-10-29 19:20 ` sashiko-bot
2026-10-29 18:47 ` [PATCH v5 6/8] dt-bindings: serial: snps-dw-apb-uart: add Allwinner A523 James Hilliard
2026-10-29 19:22 ` sashiko-bot
2026-10-29 18:47 ` [PATCH v5 7/8] serial: 8250_dw: discover Allwinner A523 FIFO depths through FCC James Hilliard
2026-10-29 19:24 ` sashiko-bot
2026-10-30 10:00 ` Ilpo Järvinen
2026-10-29 18:47 ` [PATCH v5 8/8] arm64: dts: allwinner: a523: describe the UART integration James Hilliard
2026-10-29 19:27 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-189845@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox