From: sashiko-bot@kernel.org
To: laixiangwu <laixiangwu@cmss.chinamobile.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: sc16is7xx: Fix clock leak on invalid clock frequency
Date: Fri, 30 Oct 2026 08:57:14 +0000 [thread overview]
Message-ID: <sashiko-outbox-190722@kernel.org> (raw)
In-Reply-To: <20261030085508.1882-1-laixiangwu@cmss.chinamobile.com>
> sc16is7xx_probe() enables the clock with clk_prepare_enable() early in
> the probe path. If the resulting clock frequency cannot be determined
> (neither from the clock itself, nor from the "clock-frequency" property
> or platform data), the driver bails out with -EINVAL, but it does so
> with a plain return, leaving the clock prepared and enabled.
>
> All the later error paths of the probe already jump to the out_clk
> label to disable the clock. Do the same here.
>
> Fixes: cb1b206cff46 ("serial: sc16is7xx: Use devm_clk_get_optional()")
> Signed-off-by: laixiangwu <laixiangwu@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261030085508.1882-1-laixiangwu@cmss.chinamobile.com?part=1
next prev parent reply other threads:[~2026-10-30 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 8:55 [PATCH] serial: sc16is7xx: Fix clock leak on invalid clock frequency laixiangwu
2026-10-30 8:57 ` sashiko-bot [this message]
2026-11-11 9:52 ` Xiangwu Lai
2026-11-11 13:16 ` Greg Kroah-Hartman
2026-11-12 2:13 ` Xiangwu Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-190722@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=laixiangwu@cmss.chinamobile.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox