From: sashiko-bot@kernel.org
To: "Markus Probst" <markus.probst@posteo.de>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH RESEND v4] ACPI: SPCR: Support UART clock frequency field
Date: Sat, 31 Oct 2026 20:56:50 +0000 [thread overview]
Message-ID: <sashiko-outbox-192133@kernel.org> (raw)
In-Reply-To: <20261031-acpi_spcr-v4-1-c14f00a4f33f@posteo.de>
> Prior to this patch, we assume the uart clock frequency is 1843200 Hz in
> the early console. This behaviour results in garbage console output if the
> actual uart clock frequency differs.
>
> The UART Clock Frequency field was added in the Microsoft Serial Port
> Console Redirection (SPCR) specification revision 1.08. If present, use it
> to configure the serial port with the correct uart clock frequency.
> Fallback to old behaviour if missing.
>
> Add function `setup_earlycon_with_uartclk` to set uart clock frequency
> while still allowing to reuse the same console string with
> `add_preferred_console`.
>
> Link: https://learn.microsoft.com/en-us/windows-hardware/drivers/serports/serial-port-console-redirection-table
> Signed-off-by: Markus Probst <markus.probst@posteo.de>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261031-acpi_spcr-v4-1-c14f00a4f33f@posteo.de?part=1
next prev parent reply other threads:[~2026-10-31 20:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-31 20:52 [PATCH RESEND v4] ACPI: SPCR: Support UART clock frequency field Markus Probst
2026-10-31 20:56 ` sashiko-bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-10-16 18:05 Markus Probst
2026-10-16 18:17 ` sashiko-bot
2026-09-30 15:33 Markus Probst
2026-09-30 15:45 ` sashiko-bot
2026-09-30 17:35 ` Markus Probst
2026-09-13 16:17 Markus Probst
2026-09-13 16:23 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-192133@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=markus.probst@posteo.de \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox