From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793717280; b=F0QYkBGEn2VjNk7mwlk48tG9Yeg1Dy3M28dFt50ixjtg1aIuSqHkDB8sJUL1DUD8FWBs LFY+Tb9nGCnlWGRZmCmDZjXZKV8mQ9qsgFOhmJwMNcp9gLh4Jla8PBwaatTG6r//4rkfJ Uu+HdasD4BLinKfpyV0osXdht6R2L66p5rMH9oYxUr/rumK4EZ7eTg28hr7ZsJt7UeBi1 ISd6wTxz6mbsTrZjSFP+XYbHXJJSYbSY5vPR/Ag8LSdGTHSWrCdLk+eFYxWrtgWzERbuy eXxiDk4fPK2SVPstRYrWlWofEDTfC2EPY4+P9q+wWtWXb2k7vols1B1Z3MiNCHtU+RQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793717280; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=35U9vRZipm/0ugcUNHxZ4oD7lBPqHisqrJL8z7uReys=; b=pWo9Kn7dxKkfpTCLmMhSXeuX8Yv/g2/YmfEiEplxayZYLNxRsPekZ4dWYHolVdktJKdJ xWE/Miur+6cRxv+P8Xed5Vg714gEePF9NnsA7BwmOTO+EJFrPBaLNKpDi77pyh6jYVRBz auEQqQx+DUdBA++mohqcVT+JoFnqaBncEjnVbIrHMCbScF9ZXFeHib9tBUxiM8y/zQpDD Kh7UTCTwRDxFCJqJfxdSAcGZTb0bV5hu2hVSv52Yv04mlVKMSbQI+K8YZLm54JC8Yv+oG /pEhwz/3h+HTfs3wYGy/kvw4gvQOawZljFFaYgH+lQu2+sAlbb/EtaQyQ6aOaSt5/qw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=XOb2jlGy; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E786360A2603; Tue, 3 Nov 2026 14:47:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=XOb2jlGy Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A1531F000C1; Tue, 3 Nov 2026 14:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793717279; bh=35U9vRZipm/0ugcUNHxZ4oD7lBPqHisqrJL8z7uReys=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=XOb2jlGyODvVjIsoXLfcQiibie0dXFv0flX7Bkq7YfFUUdCGP9U4bZYuD5rIE+J1J QVVQqcJ9wLtxY79RNRFPsBr5wvWN39EGIoHeohwyVD5LExUMq6fNZQD5vleYwbZu1U RRHp8sm2TlsuqMPTLpg3xjAZOLFon2zhV25A7wzEGfg58Su/olC89JSnQqdrixaGfO 9Rqa2eSAMnbZyAyxi/rAB7t+lnni8cKQlavIUW298gxJlN9Oe4/AN6K2ky2Oe+MqLk gtUQ0MIbODOhgwn5ybHL653v1Ihw7dMlBBYQt2dSbI9DmFeH4nVnl+f6pys9S55l5z J6i/00DhD0qAg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RFC 16/38] proc: don't walk through a non-directory when resolving a name Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-ext4@vger.kernel.org, "Chuck Lever" , tytso@mit.edu, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261102-work-procfs-bugfixes-v1-16-59422ed3e465@kernel.org> References: <20261102-work-procfs-bugfixes-v1-0-59422ed3e465@kernel.org> <20261102-work-procfs-bugfixes-v1-16-59422ed3e465@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 03 Nov 2026 14:47:57 +0000 X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > __xlate_proc_name() walks the components of a name like "a/b/c" and > takes whatever it finds for "a" and "b" as the directory to go on in. > It never checks that they actually are directories. So > proc_create("file/x") hangs x into the subdir tree of the regular file > "file". Nobody can look x up there, but remove_proc_subtree() on the > file removes and frees x along with it, behind the back of whoever > registered x. >=20 > pktgen passes the name the writer of "add_device" picks to > proc_create_data(), and only the part in front of the '@' has to name > a network device: >=20 > echo "add_device lo@" > /proc/net/pktgen/kpktgend_0 > echo "add_device lo@/x" > /proc/net/pktgen/kpktgend_1 > echo "rem_device_all" > /proc/net/pktgen/kpktgend_0 > [ ... ] >=20 > Reported-by: Chris Mason > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: stable@vger.kernel.org > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261102-work-procf= s-bugfixes-v1-0-59422ed3e465@kernel.org?part=3D16