From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793719150; b=e+F2aGXDmd+SwdspYuJpyPHAHt5qqjEmm5cf02Y0Zwzl1HnW/LmSsoc306/n7TC/Mona dSCH8cNiuL0nDytLGBRPyJkgtccucUnLqQC16/EEUI1r+VSzRRKuD337YahZko0hnn/Rd 4YOuhnYEa/+5WvRR8CQLfPTSWBVJmBeHMQhVzH635aYbxcpmXk6gBtLtrsQWYJtuTxuiw iO9jAn0zG4HEjutyMQo/wuOPbn4U0b8BulbFYNr5xar7KlpTfo89gb+A9CqEs36pwMgYR DW+VJujGSCR9zWtrR1gknlgmQAxAHpUrAJU7bYwcVfn5GOLnlZF8X6RuGaT+hKMqlwQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793719150; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=GJCj7Kn00SbLJvTNolj473zurqrXw24NOUW+dVEOMrc=; b=Eejaax1LlT1dEf7D6k9hQim2EknSpk9G6zJPtzl6o1ucWcalylcZslBfipI5++ilzj4n 1yeiixFE7TD3uSqoJuWEDPkQXywDlJI0n2azrUnoLtbTB63Nj8wmjuG3ltJyBZF2t048S auZvLN8vG6QLfFL+h+Ts6ghEAimDBELBZ5YY2YEb9I6+E3Px0p8isuVGjWABMbtfm5dg7 fAugpoGo1licFLAXIZDI4R3pHCkEcrlDCLtLG94hASsohB8SFQsK/fh1e37Q78FWmt5yn 3c7PiW0RoImDeePEQQTaOaWmRdv/l0FUJyqnMPSFvWkWxr7nNhyFYq2BBKM/cGq7QEw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Nsf1aJRJ; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7525606B262; Tue, 3 Nov 2026 15:19:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Nsf1aJRJ Received: by smtp.kernel.org (Postfix) with ESMTPSA id 288131F000C1; Tue, 3 Nov 2026 15:19:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793719149; bh=GJCj7Kn00SbLJvTNolj473zurqrXw24NOUW+dVEOMrc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Nsf1aJRJ1HwGj8H9IQrji7tMD3hRlznSbt7aZxlejvsSBUbWOOM4A56v1e7ylcWw7 yNjaD+1rmjfZxTXp4KbstaI/4dUC0ktxITysc9eOvhOCqvY1qUmFm7Sr9ZezYFcQF2 DaQ0Fv2TyzFXduotPcyFPlTCNxRa1UN+xZ9FXIJ9FdpOrONGlLSZJxcYjpvWQgIfFZ SD9dz0XlX5yAdz7Dq7WZFDJnK+rruhN3iD7UoXeEeQXeIuL/GYaP8qPNP0ydJo/1hw RrWedATwKabjI3pZZtfFnataKy5WrhF0JUQ86HiiatEOs4CwfaXAXaPYpFPSdjtEde u8K5nHSnx2tLQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RFC 20/23] ALSA: info: let procfs own the seq_file of text entries Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-ext4@vger.kernel.org, "Chuck Lever" , tytso@mit.edu, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261102-work-procfs-drivers-v1-20-a994bd4d3b1a@kernel.org> References: <20261102-work-procfs-drivers-v1-0-a994bd4d3b1a@kernel.org> <20261102-work-procfs-drivers-v1-20-a994bd4d3b1a@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 03 Nov 2026 15:19:07 +0000 X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > Declare the show function and let procfs open and free the seq_file. > ->proc_open() only sets up the private data and preallocates the buffer > now and ->proc_release() no longer releases the seq_file. Reading an > entry then no longer holds up its removal when the card goes away. >=20 > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261102-work-procf= s-drivers-v1-0-a994bd4d3b1a@kernel.org?part=3D20