From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793907318; b=OvvBUujklDjmbBH5ADOmO1kiBTjgGQzmBvWGceNszoZKszyVBQJB1x/VOwgrRem9Durs 1E/qutwzYoYvdcUQ35nsbZQYNiS+h5Jj+7wxxRWnVT9wT7gYPurRoU/bryg2AW+YaYxLG tSswtlMWLS04f77+bBjCbmnGuRex4TUHUI59MhMGDw9FORYBzSFbOJ9J3YI8Yj5pex0x3 zDurUEJXFzqK/Ew++1ArSrumGs9ryLJlbuHXRZm55HVxHfL3MiNexEivur1/tMpDxHbFk O1/G5AQmh0Wy+Kfv+6x1669nn+jimxwhAulgYkOKmgg0Pgvq9hGqzoqZOBXiolLokHA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793907318; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=AP/9HXvjjFp+N4Xnk9ZhfHtJP84zQAgGJz8O2YcoyD0=; b=eJjXZQDwWMm/b/zsXXStvQqp52DD+LZXmEguX/8BzV4rC5mi+ArTJm6SmANkP74xuwey Vhz4OSFrlo+AkrmBb7JzMqdkXsyReOlup//ykMSFgs9yHu2xhxWAVX9guYYnl0Ah0bO2e sycapWiCInmsql3VNRx5c+K5goPWT1D3mQLhUkFubEirR++9cnvyPNsjMrm2AXFvjNJGt mJkJ7yXMloSV7wvKmMVQDpBsBO5z1sQ8d7uRLxVisQH8hI6qfaJgic09Cihq/9qfc3ukw 0rjDPolaG3fsC3rj2KG+c5YHhqQPA/88V1zIJOYiQQeXYbhWZiY0RUJSdVB9uh8xxLg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=VV39f5So; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE45D607728A; Thu, 5 Nov 2026 19:35:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=VV39f5So Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AEA91F0089E; Thu, 5 Nov 2026 19:35:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793907317; bh=AP/9HXvjjFp+N4Xnk9ZhfHtJP84zQAgGJz8O2YcoyD0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VV39f5So1g49N7W3UbazXSKQL1BbkHKsfLDbb5QZyU2fOrbmB53+C4PMQy1tfCByM YeDx/jfn/yLKwX+us/mZVBJDDA91+KXxpBNNXFRm3QKM0f7cji3TwH5M8nHjoaQe5/ PdhGk3yZ3xaL42g/7f8054+A4X+UPyrne9kb4i1NQQwmr+H3CYFASt7DcN/tUrZHBj 2/O1yXa6ry8ceB9fU543h/I4a9F+hfGsT5rjTvnX1LOe375Qwsz5tsvk/2r3vt3BEP 3JguqV1jlUZuRL/eoYBu9vyZZu4WXiGAEVe3tKSHV+xvGFYZJ3KO+vhvrhYxYSS0a4 ypRBTWf9dhnXg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RESEND v2 02/23] proc: add pde_pin() and pde_unpin() Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-ext4@vger.kernel.org, "Chuck Lever" , tytso@mit.edu, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261104-work-procfs-core-v2-2-76ace653a773@kernel.org> References: <20261104-work-procfs-core-v2-0-76ace653a773@kernel.org> <20261104-work-procfs-core-v2-2-76ace653a773@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 05 Nov 2026 19:35:15 +0000 X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > Every call into an entry that can go away is wrapped in use_pde() and > unuse_pde(), and a permanent entry is called straight away. The read, > write, poll, ioctl, mmap and lseek methods all spell that out as the > same if-else. The next patches add a few more callers. So put it into > pde_pin() and pde_unpin() and use them everywhere. >=20 > No functional changes. >=20 > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261104-work-procf= s-core-v2-0-76ace653a773@kernel.org?part=3D2