From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793908191; b=2FEc5+O90hyir985VI+70kyxcVg6oOjlAeoJs/7/oFyrAUDyfMEZnP0+mg5xp7LStgXz 6qRfhIzVm5DrHe1h/oJEVvInCpmy2UYiLgWzCQirm57uSTR1nccLlhjjPedjW2szk13DC kZd40Bp/IPGUZARM3q7laXRSkL29csjtiO4ixRVTdsGUeoZ/AWT7MWulQ9jwN03pe9zb4 fkzwHZTeTXeT+rv8VbPojh/b1jWu8zwuH1jCkcyeUNo1DfI9bPmYY5sbVYyZzFXItZJgm srf3n9Pu69IufvGwyq32Ah8Lh+yNZAtrHgfAHJNyogmFMkMLG+elYTZ8JCUOYQlVVTw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793908191; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=wcOgF6I0KZL3tk97PgTaU7xCFlwNk82oM8K3Yy+AHys=; b=NHvG5vLfNf2TIbIWdOegzaU3rjS6Hi89gQszS1jkKG95kpEeqmW7VqDz9uEEGM9ydLoz vcr3TW5rN6aV2/2aLtxHeKrYfc9nhqF8yozttgusDQ+7jSnWkcQ1a78xyDTNO52PX297F sh/H9iytVqoCoIVjkCxqSoq11iTgiiaevdvU0zEh4hogFgYuX96PiSCTxgWuDFwa3uS++ pJ+CxtNDr+4cSKKKoOrugYj8iSQrCV0e7TAuLHFFVJttZIy5aek1+sfla0PCXkNc2mLav /6yTqIByHAMVoNMyh6bfcMqNakklwyii4TO/78C+7xpnJHyMESK6C1IZAbtXTQWaq4Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=aBpWIN4H; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66EDC6077C97; Thu, 5 Nov 2026 19:49:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=aBpWIN4H Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFBCE1F0089F; Thu, 5 Nov 2026 19:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793908191; bh=wcOgF6I0KZL3tk97PgTaU7xCFlwNk82oM8K3Yy+AHys=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=aBpWIN4H+IPXlAf4uhQaT4gTnkT8RNUC+7KT0a19CGAzuyrH2d/d5QNIzOsDfREmP OHKxJk5tkuz5k4DgXe7Wh5+1+7YWuRYhCjC2WLPI4T02sD3XGSQ7JvmzEGX7Id003S qr+pMLJ3DE26ABn/dOtypdvXbUSh/97Bq/1VIZT+pjFsEp35N5jpaqxjwMn/jnbhOE R2p5HLaB3AYWWLOynqVOowHnGoXOtdUD2DZVMSB/CNWgILqXfvQFedtAWyoFjZDWQk o2a9Hsr2lNnZH4Uzfq7jkIJjVPvL/wlCIvzLWMQ9KqbzHH+jIPNP6nT3AVZrusCM3J Mh6j2wX7Eo8Pw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RESEND v2 20/26] tty: sysrq: let procfs copy in writes to /proc/sysrq-trigger Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-ext4@vger.kernel.org, "Chuck Lever" , "Jiri Slaby" , tytso@mit.edu, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261104-work-procfs-drivers-v2-20-245e54e87116@kernel.org> References: <20261104-work-procfs-drivers-v2-0-245e54e87116@kernel.org> <20261104-work-procfs-drivers-v2-20-245e54e87116@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 05 Nov 2026 19:49:49 +0000 X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > Implement ->proc_write_buf() so procfs copies in what is written before > it pins the entry, and handle the keys from that copy. Writes larger > than PAGE_SIZE - 1 bytes fail with -EINVAL now. They used to trigger the > first key, or all of them in bulk mode. procfs allocates the copy, which > is as small as the write, opening the file allocated as much already. >=20 > Reviewed-by: Jiri Slaby > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261104-work-procf= s-drivers-v2-0-245e54e87116@kernel.org?part=3D20