Linux Serial subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Alexey Charkov" <alchark@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 4/4] serial: vt8500: Drop the port index bitmap
Date: Wed, 11 Nov 2026 20:09:48 +0000	[thread overview]
Message-ID: <sashiko-outbox-209610@kernel.org> (raw)
In-Reply-To: <20261111-vt8500-serial-cleanup-v1-4-b33594a25f87@gmail.com>

> Stop reserving a line in the vt8500_ports_in_use bitmap before probe
> acquires its resources: nothing ever clears the bit, so an early probe
> failure strands the line, and a retry then fails with -EBUSY on an
> aliased port or drifts to the next free index on an unaliased one.
> 
> Pick the line from the serial core state instead and let
> uart_add_one_port() claim it, as the core already refuses a taken line
> under its port mutex. Rely on that for concurrent probes too, so that a
> racing probe fails cleanly with no driver state to roll back.
> 
> Keep the allocation policy as is: honour an in-range "serial" alias,
> otherwise fall back to the first free line.
> 
> Fixes: 4001130df1a7 ("serial: vt8500: Add devicetree support for vt8500-serial")
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://sashiko.dev/#/bug/linux-ca000721-4a5b-4d88-bdb8-7f1e438dc81e
> Signed-off-by: Alexey Charkov <alchark@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-vt8500-serial-cleanup-v1-0-b33594a25f87@gmail.com?part=4


      reply	other threads:[~2026-11-11 20:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 19:19 [PATCH 0/4] serial: vt8500: Clean up the probe Alexey Charkov
2026-11-11 19:19 ` [PATCH 1/4] serial: vt8500: Find console ports in the serial core state Alexey Charkov
2026-11-11 19:42   ` sashiko-bot
2026-11-11 19:19 ` [PATCH 2/4] serial: vt8500: Use devm_clk_get_enabled() Alexey Charkov
2026-11-11 19:52   ` sashiko-bot
2026-11-11 19:19 ` [PATCH 3/4] serial: vt8500: Handle uart_add_one_port() failure Alexey Charkov
2026-11-11 20:00   ` sashiko-bot
2026-11-11 19:19 ` [PATCH 4/4] serial: vt8500: Drop the port index bitmap Alexey Charkov
2026-11-11 20:09   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-209610@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=alchark@gmail.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox