From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH v7 08/10] dmaengine: dw: drain the tasklet before releasing channel resources
Date: Sun, 15 Nov 2026 07:37:28 +0000 [thread overview]
Message-ID: <sashiko-outbox-215265@kernel.org> (raw)
In-Reply-To: <20261115-submit-dw-dma-synchronize-v1-v7-8-8d58f3d49e4d@gmail.com>
> The controller tasklet invokes callbacks after dropping the channel lock.
> Releasing a channel can therefore clear its configuration and disable the
> controller while that tasklet run is still using them.
>
> Disable the tasklet before clearing channel resources and re-enable it
> after updating the controller's in-use mask. This waits for an executing
> run while preserving pending schedules for the other channels. Have a
> pending run return before accessing registers when the last channel has
> already been released.
>
> Fixes: 3bfb1d20b547 ("dmaengine: Driver for the Synopsys DesignWare DMA controller")
> Cc: stable@vger.kernel.org
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261115-submit-dw-dma-synchronize-v1-v7-0-8d58f3d49e4d@gmail.com?part=8
next prev parent reply other threads:[~2026-11-15 7:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 7:19 [PATCH v7 00/10] dmaengine: dw: serialize completion and termination James Hilliard
2026-11-15 7:19 ` [PATCH v7 01/10] dmaengine: dw: Fix XFER bit set, but channel not idle error James Hilliard
2026-11-15 7:33 ` sashiko-bot
2026-11-15 7:19 ` [PATCH v7 02/10] dmaengine: dw: serialize error recovery with channel termination James Hilliard
2026-11-15 7:25 ` sashiko-bot
2026-11-15 7:19 ` [PATCH v7 03/10] dmaengine: dw: complete cookies before releasing the channel lock James Hilliard
2026-11-15 7:24 ` sashiko-bot
2026-11-15 7:19 ` [PATCH v7 04/10] dmaengine: dw: extract hardware-LLP residue calculation James Hilliard
2026-11-15 7:22 ` sashiko-bot
2026-11-15 7:19 ` [PATCH v7 05/10] dmaengine: dw: calculate residue in the status getter James Hilliard
2026-11-15 7:31 ` sashiko-bot
2026-11-15 7:19 ` [PATCH v7 06/10] dmaengine: dw: simplify transfer-complete handling James Hilliard
2026-11-15 7:23 ` sashiko-bot
2026-11-15 7:19 ` [PATCH v7 07/10] dmaengine: dw: report residue for queued transfers James Hilliard
2026-11-15 7:29 ` sashiko-bot
2026-11-15 7:19 ` [PATCH v7 08/10] dmaengine: dw: drain the tasklet before releasing channel resources James Hilliard
2026-11-15 7:37 ` sashiko-bot [this message]
2026-11-15 7:19 ` [PATCH v7 09/10] dmaengine: dw: synchronize completion callbacks James Hilliard
2026-11-15 7:31 ` sashiko-bot
2026-11-15 7:19 ` [PATCH v7 10/10] dmaengine: dw: Prevent tx-status calling DMA-desc callback James Hilliard
2026-11-15 7:34 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215265@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox