From: sashiko-bot@kernel.org
To: "Sherry Sun (OSS)" <sherry.sun@oss.nxp.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: serial: fsl_lpuart: fix the RTSWATER field mask
Date: Tue, 17 Nov 2026 08:43:38 +0000 [thread overview]
Message-ID: <sashiko-outbox-218424@kernel.org> (raw)
In-Reply-To: <20261117-lpuart_rtswater-v1-1-c2a95ae804f5@nxp.com>
> From: Sherry Sun <sherry.sun@nxp.com>
>
> UARTMODIR_RTSWATER is currently defined as GENMASK(10, 8), which
> matches older i.MX implementations where the RTSWATER field occupies
> MODIR[10:8].
>
> However, newer i.MX SoCs extend the RTSWATER field width, for example:
> i.MX8ULP MODIR[10:8]
> i.MX93/95 MODIR[11:8]
> i.MX8QM/8DXL MODIR[12:8]
> i.MX8QXP MODIR[13:8]
>
> The driver programs the RTS watermark using:
> FIELD_PREP(UARTMODIR_RTSWATER, sport->rxfifo_size >> 1)
>
> [ ... ]
> Also clear the existing watermark field before inserting the intended
> value.
>
> Fixes: ecba98f9ddf4 ("tty: serial: fsl_lpuart: set RTS watermark for lpuart")
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-lpuart_rtswater-v1-1-c2a95ae804f5@nxp.com?part=1
prev parent reply other threads:[~2026-11-17 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 8:40 [PATCH] tty: serial: fsl_lpuart: fix the RTSWATER field mask Sherry Sun (OSS)
2026-11-17 8:43 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218424@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sherry.sun@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox