Linux Serial subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH v9 3/6] dmaengine: dw: use virt-dma for descriptor and callback ownership
Date: Tue, 17 Nov 2026 23:08:35 +0000	[thread overview]
Message-ID: <sashiko-outbox-219784@kernel.org> (raw)
In-Reply-To: <20261117-submit-dw-dma-synchronize-v1-v9-3-7dc066ed0bcf@gmail.com>

> The status getter can invoke a client's completion callback while polling
> the hardware. An 8250 RX timeout calls it with the port lock held, and the
> callback takes that same lock. Termination also lacks a synchronization
> hook to wait for callbacks already detached from the channel's queues.
> 
> Use virt-dma for transaction queues, cookie completion and callback
> delivery. Keep the active transaction and hardware state under vc.lock.
> Polling still processes RAW.XFER and advances software-LLP blocks, so
> clients such as catpt can complete transfers with the controller interrupt
> masked. Client callbacks run only from the per-channel virt-dma tasklet.
> 
> Submit only the first block of each transaction to virt-dma. Its child
> LLIs remain on the driver's hardware-chain list and are freed together
> after the callback returns. Keep the controller tasklet for hardware
> event processing and error recovery.
> [ ... ]
> Fixes: b36f09c3c441 ("dmaengine: Add transfer termination synchronization support")
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Link: https://lore.kernel.org/r/20240911184710.4207-3-fancer.lancer@gmail.com
> Link: https://lore.kernel.org/r/avrHOJ-fVZOO32bI@ashevche-desk.local
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-submit-dw-dma-synchronize-v1-v9-0-7dc066ed0bcf@gmail.com?part=3


  reply	other threads:[~2026-11-17 23:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 22:48 [PATCH v9 0/6] dmaengine: dw: serialize completion and termination James Hilliard
2026-11-17 22:48 ` [PATCH v9 1/6] dmaengine: dw: Fix XFER bit set, but channel not idle error James Hilliard
2026-11-17 23:03   ` sashiko-bot
2026-11-17 22:48 ` [PATCH v9 2/6] dmaengine: dw: serialize error recovery with channel termination James Hilliard
2026-11-17 22:54   ` sashiko-bot
2026-11-17 22:48 ` [PATCH v9 3/6] dmaengine: dw: use virt-dma for descriptor and callback ownership James Hilliard
2026-11-17 23:08   ` sashiko-bot [this message]
2026-11-17 22:48 ` [PATCH v9 4/6] dmaengine: dw: extract hardware-LLP residue calculation James Hilliard
2026-11-17 22:54   ` sashiko-bot
2026-11-17 22:48 ` [PATCH v9 5/6] dmaengine: dw: calculate residue in the status getter James Hilliard
2026-11-17 23:03   ` sashiko-bot
2026-11-17 22:48 ` [PATCH v9 6/6] dmaengine: dw: report residue for queued transfers James Hilliard
2026-11-17 22:57   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219784@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=james.hilliard1@gmail.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox