Linux Serial subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Hyunjung Ko" <hj351016@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: pic32_uart: don't enable clock with interrupts disabled
Date: Wed, 18 Nov 2026 11:20:34 +0000	[thread overview]
Message-ID: <sashiko-outbox-220817@kernel.org> (raw)
In-Reply-To: <20261118111521.1003717-1-hj351016@gmail.com>

> pic32_uart_startup() calls clk_prepare_enable() with interrupts disabled
> via local_irq_save(). clk_prepare() calls might_sleep() unconditionally,
> so this can sleep in atomic context.
> 
> Interrupts are only disabled to serialize the UART register
> initialization that follows; the clock must be enabled before those
> registers can be accessed anyway. Enable the clock before disabling
> interrupts.
> 
> Fixes: 157b9394709e ("serial: pic32_uart: Add PIC32 UART driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Hyunjung Ko <hj351016@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118111521.1003717-1-hj351016@gmail.com?part=1


      reply	other threads:[~2026-11-18 11:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 11:15 [PATCH] serial: pic32_uart: don't enable clock with interrupts disabled Hyunjung Ko
2026-11-18 11:20 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220817@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=hj351016@gmail.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox