From: sashiko-bot@kernel.org
To: "Haoli Zhang" <26031212468@stu.xidian.edu.cn>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] tty: vt: protect tty lifetime in keyboard path
Date: Thu, 19 Nov 2026 02:52:13 +0000 [thread overview]
Message-ID: <sashiko-outbox-222348@kernel.org> (raw)
In-Reply-To: <20261119024207.4075962-1-26031212468@stu.xidian.edu.cn>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] tty: vt: patch revision commentary and apology in commit message
body
--
commit 07a0cb83e09876e569aba67b5389fa9413ff391d
Author: Haoli Zhang <26031212468@stu.xidian.edu.cn>
tty: vt: protect tty lifetime in keyboard path
This commit uses the tty_port_tty guard in fn_hold() and tty_port_tty_set()
in con_install() and con_shutdown() to protect the tty lifetime against
concurrent port dissociation.
> I apologize for the v1 patch. It included a NULL check inside the
> conditional tty_port_tty guard, even though the guard skips its body when
> no tty is associated. That check was redundant and made the guard usage
> unclear. I have removed it in this version.
[Severity: Low]
This isn't a bug, but v1-to-v2 revision commentary and notes to reviewers
belong below the "---" tearline so they do not become part of the permanent
git commit log.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119024207.4075962-1-26031212468@stu.xidian.edu.cn?part=1
prev parent reply other threads:[~2026-11-19 2:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 2:42 [PATCH v2] tty: vt: protect tty lifetime in keyboard path Haoli Zhang
2026-11-19 2:52 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222348@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=26031212468@stu.xidian.edu.cn \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox