Linux Serial subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Fuyao Kashizuku" <fuyao@sjterm.com>, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_dwlib: Restore NOTEMT for em485
Date: Sat, 21 Nov 2026 06:42:23 +0000	[thread overview]
Message-ID: <sashiko-outbox-226704@kernel.org> (raw)
In-Reply-To: <awE7o4z1DMGb-YMg@debian.cyg>

> From: Fuyao Kashizuku <fuyao@sjterm.com>
> 
> A DesignWare UART using software RS485 can transmit one byte and then
> leave the next write queued indefinitely.
> 
> dw8250_setup_port() sets UART_CAP_NOTEMT because the UART does not
> interrupt when the shift register becomes empty. If neither hardware
> nor platform data supplies a component parameter register (CPR) value,
> the driver leaves UPF_FIXED_TYPE clear. When autoconfig() identifies
> a 16550A, it replaces the capabilities with the type defaults and drops
> UART_CAP_NOTEMT.
> 
> If the TX FIFO empties while the shift register is still busy, __stop_tx()
> then returns without arming the stop timer or clearing THRI. With no
> further interrupt when the last bit leaves the wire, em485 can stay in
> transmit mode and a subsequent write can remain queued.
> 
> Restore UART_CAP_NOTEMT in the DW software RS485 configuration callback.
> This lets the existing em485 timer finish the transmission and release
> RTS after the last character.
> 
> Fixes: 5ff33917faca ("serial: 8250_dwlib: Implement SW half duplex support")
> Assisted-by: Codex:gpt-6
> Signed-off-by: Fuyao Kashizuku <fuyao@sjterm.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/awE7o4z1DMGb-YMg@debian.cyg?part=1

      reply	other threads:[~2026-11-21  6:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21  6:35 [PATCH] serial: 8250_dwlib: Restore NOTEMT for em485 Fuyao Kashizuku
2026-11-21  6:42 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226704@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=fuyao@sjterm.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox