From: sashiko-bot@kernel.org
To: "Bramuel Barack" <bramwelbarack89@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: serial: samsung_tty: fix -Wformat-overflow warnings for clk_name
Date: Sat, 21 Nov 2026 19:26:15 +0000 [thread overview]
Message-ID: <sashiko-outbox-227303@kernel.org> (raw)
In-Reply-To: <20261121192158.44872-1-bramwelbarack89@gmail.com>
> MAX_CLK_NAME_LENGTH is currently 15, which only leaves room for a
> single-digit index after the 13-character "clk_uart_baud" prefix and
> terminating NUL byte. Because the clock indices (cnt, clk_num, clk_sel)
> are u8 values (0-255), building with W=1 triggers -Werror=format-overflow
> warnings at the sprintf() call sites.
>
> Increase MAX_CLK_NAME_LENGTH to 17 to accommodate the full u8 range and
> replace the three sprintf() calls with snprintf().
>
> Signed-off-by: Bramuel Barack <bramwelbarack89@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261121192158.44872-1-bramwelbarack89@gmail.com?part=1
prev parent reply other threads:[~2026-11-21 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 19:21 [PATCH] tty: serial: samsung_tty: fix -Wformat-overflow warnings for clk_name Bramuel Barack
2026-11-21 19:26 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-227303@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bramwelbarack89@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox