From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+f6cb41c144427dc0796a@syzkaller.appspotmail.com
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: [PATCH Next] vt: move vc_saved_screen to within tty allocated judgment
Date: Tue, 9 Sep 2025 08:51:22 +0800 [thread overview]
Message-ID: <tencent_CAD45DB31906CF890DBB25AB0DED12205D07@qq.com> (raw)
In-Reply-To: <68bf244a.050a0220.192772.0882.GAE@google.com>
Everything starts with the assumption that a tty has been allocated.
Therefore, Move it to within the tty allocation check.
Fixes: 23743ba64709 ("vt: add support for smput/rmput escape codes")
Reported-by: syzbot+f6cb41c144427dc0796a@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=f6cb41c144427dc0796a
Tested-by: syzbot+f6cb41c144427dc0796a@syzkaller.appspotmail.com
Signed-off-by: Edward Adam Davis <eadavis@qq.com>
---
drivers/tty/vt/vt.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 1d9abcfac4c9..6e0089b85c27 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -1341,10 +1341,10 @@ struct vc_data *vc_deallocate(unsigned int currcons)
vc_uniscr_set(vc, NULL);
kfree(vc->vc_screenbuf);
vc_cons[currcons].d = NULL;
- }
- if (vc->vc_saved_screen != NULL) {
- kfree(vc->vc_saved_screen);
- vc->vc_saved_screen = NULL;
+ if (vc->vc_saved_screen != NULL) {
+ kfree(vc->vc_saved_screen);
+ vc->vc_saved_screen = NULL;
+ }
}
return vc;
}
--
2.43.0
next prev parent reply other threads:[~2025-09-09 0:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 18:45 [syzbot] [serial?] general protection fault in vc_deallocate syzbot
2025-09-09 0:51 ` Edward Adam Davis [this message]
2025-09-09 6:35 ` [PATCH Next] vt: move vc_saved_screen to within tty allocated judgment Jiri Slaby
2025-09-10 6:21 ` [syzbot] [serial?] general protection fault in vc_deallocate syzbot
2025-09-10 6:48 ` Jiri Slaby
2025-09-10 7:20 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_CAD45DB31906CF890DBB25AB0DED12205D07@qq.com \
--to=eadavis@qq.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=syzbot+f6cb41c144427dc0796a@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox