From: Dave Hansen <dave.hansen@intel.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: linux-sgx@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
stable@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Sean Christopherson <seanjc@google.com>,
Jethro Beekman <jethro@fortanix.com>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] x86/sgx: Free backing memory after faulting the enclave page
Date: Wed, 2 Mar 2022 08:40:29 -0800 [thread overview]
Message-ID: <1f06eb77-1c08-33f6-d784-8eeee25f6f6a@intel.com> (raw)
In-Reply-To: <Yh7LUU401weiq0ew@iki.fi>
On 3/1/22 17:41, Jarkko Sakkinen wrote:
> On Tue, Mar 01, 2022 at 09:54:14AM -0800, Dave Hansen wrote:
>> On 3/1/22 04:58, Jarkko Sakkinen wrote:
>>> @@ -32,14 +58,16 @@ static int __sgx_encl_eldu(struct sgx_encl_page *encl_page,
>>> else
>>> page_index = PFN_DOWN(encl->size);
>>>
>>> + page_pcmd_off = sgx_encl_get_backing_page_pcmd_offset(encl, page_index);
>>> +
>>> ret = sgx_encl_lookup_backing(encl, page_index, &b);
>>> if (ret)
>>> return ret;
>> What tree is this against? It looks like it might be on top of
>> Kristen's overcommit series.
>>
>> It would be best if you could test this on top of tip/sgx. Kristen
>> changed code in this area as well.
> I rebased this against latest stuff and now I did a sanity check:
>
> $ git fetch tip
> remote: Enumerating objects: 75, done.
> remote: Counting objects: 100% (75/75), done.
> remote: Compressing objects: 100% (12/12), done.
> remote: Total 77 (delta 65), reused 65 (delta 63), pack-reused 2
> Unpacking objects: 100% (77/77), 34.07 KiB | 157.00 KiB/s, done.
>>From git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
> 161a9a33702a..cedd3614e5d9 perf/core -> tip/perf/core
> 6255b48aebfd..25795ef6299f sched/core -> tip/sched/core
>
> $ git rebase tip/x86/sgx
> Current branch master is up to date.
Are you sure you didn't also rebase all of Kristen's work along with
your one patch? How many patches did you rebase?
You might want to do:
git log tip/x86/sgx..
next prev parent reply other threads:[~2022-03-02 16:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 12:58 [PATCH v5] x86/sgx: Free backing memory after faulting the enclave page Jarkko Sakkinen
2022-03-01 17:54 ` Dave Hansen
2022-03-02 1:41 ` Jarkko Sakkinen
2022-03-02 16:40 ` Dave Hansen [this message]
2022-03-03 22:47 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f06eb77-1c08-33f6-d784-8eeee25f6f6a@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=jethro@fortanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox