* [PATCH] x86/sgx: Fix a build error introduced by WARN->ENCLS_WARN conversion
@ 2020-03-14 3:30 Sean Christopherson
2020-03-15 18:11 ` Jarkko Sakkinen
0 siblings, 1 reply; 3+ messages in thread
From: Sean Christopherson @ 2020-03-14 3:30 UTC (permalink / raw)
To: Jarkko Sakkinen; +Cc: linux-sgx
Remove an unwanted param when invoking ENCLS_WARN on EREMOVE failure.
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
---
arch/x86/kernel/cpu/sgx/reclaim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/sgx/reclaim.c b/arch/x86/kernel/cpu/sgx/reclaim.c
index 9afe5e7d50a6..eb5008c37b64 100644
--- a/arch/x86/kernel/cpu/sgx/reclaim.c
+++ b/arch/x86/kernel/cpu/sgx/reclaim.c
@@ -352,7 +352,7 @@ static void sgx_reclaimer_write(struct sgx_epc_page *epc_page,
if (atomic_read(&encl->flags) & SGX_ENCL_DEAD) {
ret = __eremove(sgx_epc_addr(epc_page));
- ENCLS_WARN(ret, "EREMOVE returned %d\n", ret);
+ ENCLS_WARN(ret, "EREMOVE returned %d\n");
} else {
sgx_encl_ewb(epc_page, backing);
}
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] x86/sgx: Fix a build error introduced by WARN->ENCLS_WARN conversion
2020-03-14 3:30 [PATCH] x86/sgx: Fix a build error introduced by WARN->ENCLS_WARN conversion Sean Christopherson
@ 2020-03-15 18:11 ` Jarkko Sakkinen
2020-03-15 18:17 ` Jarkko Sakkinen
0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Sakkinen @ 2020-03-15 18:11 UTC (permalink / raw)
To: Sean Christopherson; +Cc: linux-sgx
On Fri, Mar 13, 2020 at 08:30:51PM -0700, Sean Christopherson wrote:
> Remove an unwanted param when invoking ENCLS_WARN on EREMOVE failure.
>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Applied [1].
Had not set $LINUX_OVERRIDE_SRCDIR when building my BuildRoot
environment which caused buildroot to pull remote version of the kernel
tree instead of local. I.e. ended up compiling kernel without the change
that caused this compilation failure.
/Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/sgx: Fix a build error introduced by WARN->ENCLS_WARN conversion
2020-03-15 18:11 ` Jarkko Sakkinen
@ 2020-03-15 18:17 ` Jarkko Sakkinen
0 siblings, 0 replies; 3+ messages in thread
From: Jarkko Sakkinen @ 2020-03-15 18:17 UTC (permalink / raw)
To: Sean Christopherson; +Cc: linux-sgx
On Sun, Mar 15, 2020 at 08:11:30PM +0200, Jarkko Sakkinen wrote:
> On Fri, Mar 13, 2020 at 08:30:51PM -0700, Sean Christopherson wrote:
> > Remove an unwanted param when invoking ENCLS_WARN on EREMOVE failure.
> >
> > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
>
> Applied [1].
>
> Had not set $LINUX_OVERRIDE_SRCDIR when building my BuildRoot
> environment which caused buildroot to pull remote version of the kernel
> tree instead of local. I.e. ended up compiling kernel without the change
> that caused this compilation failure.
Not that this is an excuse to leak that kind of code, just trying to
backtrack things whenever this kind of stuff happens. Try to be more
careful next time.
/Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-15 18:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-14 3:30 [PATCH] x86/sgx: Fix a build error introduced by WARN->ENCLS_WARN conversion Sean Christopherson
2020-03-15 18:11 ` Jarkko Sakkinen
2020-03-15 18:17 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).