From: Jarkko Sakkinen <jarkko@kernel.org>
To: linux-sgx@vger.kernel.org
Cc: Jarkko Sakkinen <jarkko@kernel.org>,
Borislav Petkov <bp@alien8.de>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, akpm@linux-foundation.org,
andriy.shevchenko@linux.intel.com, asapek@google.com,
cedric.xing@intel.com, chenalexchen@google.com,
conradparker@google.com, cyhanish@google.com,
dave.hansen@intel.com, haitao.huang@intel.com,
kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com,
ludloff@google.com, luto@kernel.org, nhorman@redhat.com,
npmccallum@redhat.com, puiterwijk@redhat.com,
rientjes@google.com, sean.j.christopherson@intel.com,
tglx@linutronix.de, yaozhangx@google.com, mikko.ylinen@intel.com
Subject: [PATCH] selftests/x86: Fix malformed src_offset initialization
Date: Wed, 18 Nov 2020 00:36:30 +0200 [thread overview]
Message-ID: <20201117223630.17355-1-jarkko@kernel.org> (raw)
Assign src_offset just to the p_offset, when first initialized.
This has been probably copy-pasting accident (at least looks like
it).
Cc: Borislav Petkov <bp@alien8.de>
Cc: Shuah Khan <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
---
tools/testing/selftests/sgx/load.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/sgx/load.c b/tools/testing/selftests/sgx/load.c
index 07988de6b767..64976f266bae 100644
--- a/tools/testing/selftests/sgx/load.c
+++ b/tools/testing/selftests/sgx/load.c
@@ -185,7 +185,7 @@ bool encl_load(const char *path, struct encl *encl)
}
if (j == 0) {
- src_offset = (phdr->p_offset & PAGE_MASK) - src_offset;
+ src_offset = (phdr->p_offset & PAGE_MASK);
seg->prot = PROT_READ | PROT_WRITE;
seg->flags = SGX_PAGE_TYPE_TCS << 8;
--
2.27.0
next reply other threads:[~2020-11-17 22:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 22:36 Jarkko Sakkinen [this message]
2020-11-18 11:11 ` [PATCH] selftests/x86: Fix malformed src_offset initialization Borislav Petkov
2020-11-18 11:18 ` Jethro Beekman
2020-11-18 11:44 ` Borislav Petkov
2020-11-18 11:47 ` Borislav Petkov
2020-11-18 11:49 ` Borislav Petkov
2020-11-18 15:24 ` Jarkko Sakkinen
2020-11-18 15:30 ` Jarkko Sakkinen
2020-11-18 12:00 ` Jethro Beekman
2020-11-18 12:15 ` Borislav Petkov
2020-11-18 15:27 ` Jarkko Sakkinen
2020-11-18 17:09 ` Jarkko Sakkinen
2020-11-18 15:07 ` Jarkko Sakkinen
2020-11-18 17:19 ` Borislav Petkov
2020-11-18 17:58 ` Jarkko Sakkinen
2020-11-18 18:04 ` Borislav Petkov
2020-11-18 21:37 ` Jarkko Sakkinen
2020-11-18 21:54 ` Borislav Petkov
2020-11-19 1:16 ` Andy Lutomirski
2020-11-19 16:44 ` Jarkko Sakkinen
2020-11-19 16:41 ` Jarkko Sakkinen
2020-11-19 18:04 ` Borislav Petkov
2020-11-19 1:05 ` Dr. Greg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117223630.17355-1-jarkko@kernel.org \
--to=jarkko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=asapek@google.com \
--cc=bp@alien8.de \
--cc=cedric.xing@intel.com \
--cc=chenalexchen@google.com \
--cc=conradparker@google.com \
--cc=cyhanish@google.com \
--cc=dave.hansen@intel.com \
--cc=haitao.huang@intel.com \
--cc=kai.huang@intel.com \
--cc=kai.svahn@intel.com \
--cc=kmoy@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=ludloff@google.com \
--cc=luto@kernel.org \
--cc=mikko.ylinen@intel.com \
--cc=nhorman@redhat.com \
--cc=npmccallum@redhat.com \
--cc=puiterwijk@redhat.com \
--cc=rientjes@google.com \
--cc=sean.j.christopherson@intel.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=yaozhangx@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox