Re: [PATCH v3 00/25] KVM SGX virtualization support

Jarkko Sakkinen
2021-03-31T23:24:02Z

On Sun, Mar 28, 2021 at 09:01:38PM +0000, Huang, Kai wrote:
> > On Fri, Mar 19, 2021 at 08:29:27PM +1300, Kai Huang wrote:
> > > This series adds KVM SGX virtualization support. The first 14 patches
> > > starting with x86/sgx or x86/cpu.. are necessary changes to x86 and
> > > SGX core/driver to support KVM SGX virtualization, while the rest are patches
> > to KVM subsystem.
> > >
> > > This series is based against latest tip/x86/sgx, which has Jarkko's
> > > NUMA allocation support.
> > >
> > > You can also get the code from upstream branch of kvm-sgx repo on github:
> > >
> > > https://github.com/intel/kvm-sgx.git upstream
> > >
> > > It also requires Qemu changes to create VM with SGX support. You can
> > > find Qemu repo here:
> > >
> > > https://github.com/intel/qemu-sgx.git upstream
> > >
> > > Please refer to README.md of above qemu-sgx repo for detail on how to
> > > create guest with SGX support. At meantime, for your quick reference
> > > you can use below command to create SGX guest:
> > >
> > > #qemu-system-x86_64 -smp 4 -m 2G -drive
> > file=<your_vm_image>,if=virtio \
> > > -cpu host,+sgx_provisionkey \
> > > -sgx-epc id=epc1,memdev=mem1 \
> > > -object memory-backend-epc,id=mem1,size=64M,prealloc
> > >
> > > Please note that the SGX relevant part is:
> > >
> > > -cpu host,+sgx_provisionkey \
> > > -sgx-epc id=epc1,memdev=mem1 \
> > > -object memory-backend-epc,id=mem1,size=64M,prealloc
> > >
> > > And you can change other parameters of your qemu command based on your
> > needs.
> >
> > Please also put tested-by from me to all patches (including pure KVM
> > patches):
> >
> > Tested-by: Jarkko Sakkinen <jarkko@kernel.org>
> >
> > I did the basic test, i.e. run selftest in a VM. I think that is sufficient at this point.
> >
>
> Thanks Jarkko for doing the test!

Sure, have had it in my queue for some time :-)

/Jarkko