Re: [RFC PATCH v3 05/10] x86/sgx: Save the size of each EPC section

Jarkko Sakkinen
2022-04-06T10:04:04Z

On Wed, 2022-04-06 at 04:00 +0000, Zhang, Cathy wrote:
>
>
> > -----Original Message-----
> > From: Jarkko Sakkinen <jarkko@kernel.org>
> > Sent: Sunday, April 3, 2022 6:15 PM
> > To: Zhang, Cathy <cathy.zhang@intel.com>
> > Cc: linux-sgx@vger.kernel.org; x86@kernel.org; Chatre, Reinette
> > <reinette.chatre@intel.com>; Hansen, Dave <dave.hansen@intel.com>; Raj,
> > Ashok <ashok.raj@intel.com>
> > Subject: Re: [RFC PATCH v3 05/10] x86/sgx: Save the size of each EPC section
> >
> > On Fri, Apr 01, 2022 at 10:24:04PM +0800, Cathy Zhang wrote:
> > > For SGX CPUSVN update process will check all EPC pages in each section
> > > to ensure they will be marked as unused, it requires to know the size
> > > of each EPC section to end the loop.
> >
> > Why is the size required to end the loop? It's missing.
>
> How about re-write as follows:
>
> SGX CPUSVN update process should check all EPC pages to ensure they
> will be marked as unused. For EPC pages are stored in EPC sections,
> it's required to save the size of each section, as the indicator for
> the end of each section's traversing.

Sounds good to me.

BR, Jarkko