From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1FDA1B7F4 for ; Thu, 2 May 2024 22:41:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714689663; cv=none; b=qv1f/Em+WFt0G/5CHtOxpYV8Llt9Kc4ScPFNBkxrRT7JR4LnT1rftkEmKAG37RMhbpzQYarPbmdM8b1nAKK7u0Kn0Wb1xz5blRosxPny++tdvm47mB+ckFUiEbZmoSM4dD4cIFIwA6qsMi8mcEPNRchdxFWOEqf0WXngxFxxSiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714689663; c=relaxed/simple; bh=bzyP4Xdw6nGRMa8O/ZIWOZc2YGpey8Rpt1THkkiSlKE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NSwJh+U4mYWVDJaVIJnEl1GtyaQ2ET1vnZZW8y65CNYRq4foUcH58od7SnAuVX4sB8GtC0iJcrc0Kt3qtAtQ5soyDWC41g40K0W2dQlSrYXxOFWc4Xn6P/fWLMZEieNEWtKeuMk8Dm+UsmTK5C9VevdEnIGe87Dn96yd/x+Gj+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=J8qjv+4O; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="J8qjv+4O" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6ecff9df447so8241376b3a.1 for ; Thu, 02 May 2024 15:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714689661; x=1715294461; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/L9jD35jpO4uNtUxWEojKtoKI6VMvNDOlsLmuwoeTBY=; b=J8qjv+4OwWekS+smq2pAOO2aD+7G0zxDDskE6DxYIMEFCqOJDEWRbgw67BNbn/LqVp /dF4BxMfu/exf8AdUS3KFyACeksI+tvM7dHgD2xT2KgOJi96dSQomKCnPmIE7NeiHkcA 3qUG8xEx6vCC85Cn4OMcuMtdSxHYd464PTSqM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714689661; x=1715294461; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/L9jD35jpO4uNtUxWEojKtoKI6VMvNDOlsLmuwoeTBY=; b=Exjn9tB4FzWeC8MJvubW/VjQ30gpYAvJt1FA30e4kVx4UtHomXvdDpdrdLoJkGPFfa waiUoGp/+NF9jQRq29qknhepLpMhmJ/fG062hcBV1qyDSQ7dgJMRpe8mbfie6Atj2kL7 XfcvIrrNHB89O3M6a919uZBeiOitqHP+6Y40EKDRKO0JY535OvZlfzi/ArfP0a4xdHZD YJuaGKiNWVkFcmGPdaLGlHTCKB+WJO1iJmoH/kiL0BVqlHSgHTLORYQ5XiM1GkAvsTMZ 7rcxrc5GU565pN/M/k9QqNsTCXdi8SQvKu7GxWEVho95OKRZDJMfvgW4cuehx7D0GOC4 aNvQ== X-Forwarded-Encrypted: i=1; AJvYcCVJmdbGJ2HynHlYAspN7++crrD6ZTzDNXUriGTzQOR/m+hY1P9ZczLKW9MPFBmRDYBe0lFwyDz7WIKs0zaFqPJqSTIMv/2CczMd X-Gm-Message-State: AOJu0YzdjYzJUOJbflRwj1n0Nt0enfvi0HmGI7QKiIkrY9fNAeyiqjcW iot8XnIrEK2d5/UZDCexoZKCz/OmQK1GzBZ/7oBBLWMKwBqlYPERwrB7BHAi+w== X-Google-Smtp-Source: AGHT+IHT/crKZRZ/k6RhvANBVZPADnzOe9chhI8JjANxhrQb7VX4JbkZba2YNbbf5dsZ8cKd3o/FlQ== X-Received: by 2002:a05:6a20:5530:b0:1ad:8606:6484 with SMTP id ko48-20020a056a20553000b001ad86066484mr1120307pzb.8.1714689661156; Thu, 02 May 2024 15:41:01 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id s185-20020a625ec2000000b006ed64f4767asm1845468pfb.112.2024.05.02.15.41.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 15:41:00 -0700 (PDT) Date: Thu, 2 May 2024 15:41:00 -0700 From: Kees Cook To: Sean Christopherson Cc: Mark Brown , Edward Liaw , shuah@kernel.org, Jaroslav Kysela , Takashi Iwai , Jiri Kosina , Benjamin Tissoires , Paolo Bonzini , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Andrew Morton , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-input@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org Subject: Re: [PATCH v1 00/10] Define _GNU_SOURCE for sources using Message-ID: <202405021540.3FF73DF47@keescook> References: <20240430235057.1351993-1-edliaw@google.com> Precedence: bulk X-Mailing-List: linux-sgx@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, May 01, 2024 at 06:24:36AM -0700, Sean Christopherson wrote: > On Wed, May 01, 2024, Mark Brown wrote: > > On Tue, Apr 30, 2024 at 11:50:09PM +0000, Edward Liaw wrote: > > > 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced > > > asprintf into kselftest_harness.h, which is a GNU extension and needs > > > _GNU_SOURCE to either be defined prior to including headers or with the > > > -D_GNU_SOURCE flag passed to the compiler. > > > > This seems like something that should be handled centrally rather than > > having to go round and audit the users every time some update is made. > > +1. > > And if for some reason unilaterally defining _GNU_SOURCE in > tools/testing/selftests/lib.mk isn't an option, we should at least have > kselftest_harness.h assert instead of making a futile attempt to provide its own > definition, e.g. > > diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h > index 4fd735e48ee7..6741b4f20f25 100644 > --- a/tools/testing/selftests/kselftest_harness.h > +++ b/tools/testing/selftests/kselftest_harness.h > @@ -51,7 +51,7 @@ > #define __KSELFTEST_HARNESS_H > > #ifndef _GNU_SOURCE > -#define _GNU_SOURCE > +static_assert(0, "Using the kselftests harness requires building with _GNU_SOURCE"); > #endif > #include > #include Yeah, let's fix centrally. I like this approach. -- Kees Cook